Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to create semconv-security-approver #580

Closed
trisch-me opened this issue Dec 4, 2023 · 10 comments
Closed

Request to create semconv-security-approver #580

trisch-me opened this issue Dec 4, 2023 · 10 comments
Assignees

Comments

@trisch-me
Copy link
Contributor

trisch-me commented Dec 4, 2023

Hi everyone, I would like to create a group semconv-security-approver for all PRs related to security fields in following namespaces (some of them are not present now(*) but will be added soon):

  • process
  • tls
  • dll*
  • dns*
  • file*
  • registry*
  • user*
  • vulnerability*
  • x509 Certificate*
  • threat*
  • and more namespaces to come into security field...

Please add @trisch-me to the group and let's keep this issue open until we have a quorum for this approvers group

Also please let me know if I need to create a project in addition to group.

@arminru
Copy link
Member

arminru commented Jan 19, 2024

For reference: See open-telemetry/community#1838 for the pending project proposal.

@trisch-me
Copy link
Contributor Author

@joaopgrassi @joaopgrassi should we proceed with this approver group for those namespaces we already have?
i.e. process, tls, file? User and rule are coming soon as well

@joaopgrassi
Copy link
Member

Hum good question. Not sure if we need the project to be merged first for creating the groups or if the groups can be created already. Never got much involved into the github management things. I will ask the other maintainers.

@danielgblanco
Copy link

The project has now been approved and merged! 🎉 That should unblock this

@danielgblanco
Copy link

However, for future reference, issues for GH team creation and membership are normally handled in the https://github.com/open-telemetry/community repo.

@trisch-me
Copy link
Contributor Author

@danielgblanco I saw Issues and PRs in this repo for previous groups, for example #510, #294, #529

@trask
Copy link
Member

trask commented May 8, 2024

Creating GitHub teams can only be done currently by Technical Committee members. Some of the maintainers of this repo are TC members so it has kind of worked, but it's probably better in the future to follow the process other SIGs use and open a community issue where any TC member can pick up and create the team.

@trisch-me
Copy link
Contributor Author

should I move it then to the other repo?
@trask @danielgblanco ?

@trask
Copy link
Member

trask commented May 8, 2024

I'd open a new "repository maintenance" community issue scoped just to creating the team and listing the members, check out open-telemetry/community#1964

@trisch-me
Copy link
Contributor Author

closing this one in favor of open-telemetry/community#2100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants