Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace/http: Add semantic convention for total request and response length #38

Closed
kamalmarhubi opened this issue May 17, 2023 · 2 comments · Fixed by #84
Closed

trace/http: Add semantic convention for total request and response length #38

kamalmarhubi opened this issue May 17, 2023 · 2 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request

Comments

@kamalmarhubi
Copy link
Contributor

The current http.request_content_length and http.response_content_length are specified to be the length of the body excluding headers. I'd like to add an attribute for the total message size.

For names, I think http.request_length and http.response_length make the most sense.

Rationale:

@kamalmarhubi
Copy link
Contributor Author

Just caught up on the effect of open-telemetry/opentelemetry-specification#3355 which. The ECS names for the fields I'd like are:

By analogy with the renamings introduced in that PR, the new attributes should be

  • http.request.size
  • http.response.size

kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Jun 6, 2023
These attributes are the number of bytes in the request or response,
including headers. The names were chosen by taking the [ECS HTTP fields]
and replacing `bytes` with `size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
@trask
Copy link
Member

trask commented Jun 8, 2023

just adding the same heads up here from #84 (comment) (for anyone else viewing the issue):

the HTTP semantic convention WG isn't considering any additions until the HTTP semantic conventions have at least been marked Frozen, so it may be a few weeks until we get to reviewing this proposal

kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Feb 9, 2024
These attributes are the number of bytes in the request or response,
including control data, headers, body, and trailers. The names were
chosen by taking the [ECS HTTP fields] and replacing `bytes` with
`size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Feb 12, 2024
These attributes are the number of bytes in the request or response,
including control data, headers, body, and trailers. The names were
chosen by taking the [ECS HTTP fields] and replacing `bytes` with
`size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Feb 12, 2024
These attributes are the number of bytes in the request or response,
including control data, headers, body, and trailers. The names were
chosen by taking the [ECS HTTP fields] and replacing `bytes` with
`size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Feb 12, 2024
These attributes are the number of bytes in the request or response,
including control data, headers, body, and trailers. The names were
chosen by taking the [ECS HTTP fields] and replacing `bytes` with
`size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
@github-actions github-actions bot added the Stale label Feb 19, 2024
kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Feb 20, 2024
These attributes are the number of bytes in the request or response,
including control data, headers, body, and trailers. The names were
chosen by taking the [ECS HTTP fields] and replacing `bytes` with
`size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
kamalmarhubi added a commit to kamalmarhubi/semantic-conventions that referenced this issue Feb 20, 2024
These attributes are the number of bytes in the request or response,
including control data, headers, body, and trailers. The names were
chosen by taking the [ECS HTTP fields] and replacing `bytes` with
`size`, as for `http.request.content.size`.

closes open-telemetry#38

[ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
@joaopgrassi joaopgrassi removed the Stale label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants