Add k8s.container.status.last_terminated_reason to semantic conventions.

[povilasv]

Area(s)

area:k8s

Is your change request related to a problem? Please describe.

We recently added k8s.container.status_last_terminated_reason to kubernetes cluster receiver. And we would like to add resource attribute k8s.container.status_last_terminated_reason to existing semantic conventions.

Edit: It was agreed that this attribute is better named k8s.container.status.last_terminated_reason

Reference open-telemetry/opentelemetry-collector-contrib#31505 (comment)

Also issue: open-telemetry/opentelemetry-collector-contrib#31282

Describe the solution you'd like

Add resource attribute k8s.container.status_last_terminated_reason to existing semantic conventions.

Describe alternatives you've considered

No response

Additional context

No response

[joaopgrassi]

Given the example and structure is complex for status

open-telemetry/opentelemetry-collector-contrib#31282 (comment)

kubectl get pod X -o yaml

apiVersion: v1
kind: Pod
...
status:
  containerStatuses:
  - containerID: containerd://07ff7db2706d20ddd26c6257c1c1dbf176917f855c7feef0e05db88159b1584d
    image: image
    imageID:  imageId
    lastState:
      terminated:
        containerID: containerid
        exitCode: 2
        finishedAt: "2024-02-05T23:17:38Z"
        reason: Error
        startedAt: "2024-02-05T23:17:33Z"

I think we should probably have it more structured. Maybe something like k8s.container.status.last_terminated_reason. Because then we could add more things under status, such as the container id and etc.

You also added a metric to the collector, right? This metric should also probably be added to the semconv.

@povilasv will you be working in adding these?

[povilasv]

You also added a metric to the collector, right? This metric should also probably be added to the semconv.

Yes I did, I like k8s.container.status.last_terminated_reason will work on it when I will find more time and then will change what we did in k8scluster receiver.

[joaopgrassi]

Great, then I will assign this to you if that's ok :)

[ChrsMark]

The issue's title talks about adding k8s.container.status_last_terminated_reason but the PR adds the k8s.container.status.last_terminated_reason which is of course aligned with the Collector's implementation. That's most probably after #922 (comment).

@povilasv do you think it would make sense to edit the tittle and the description to avoid any possible confusion on this from future readers?

[povilasv]

So basically I intended to add the first version, but after the #922 (comment) comment we agreed that its better to be named k8s.container.status.last_terminated_reason ,

Should I keep it as is for historical reasons or should I change it to match the PR?

[ChrsMark]

Since the title was fixed I guess we are fine. If you want additionally to erase the old version of the attribute on the description and mention the final one that would be great.