Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http body size metrics to match attribute names #247

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 13, 2023

Fixes #121

Changes

Renames http.server.request.size metric to http.server.request.body.size and http.server.response.size metric to http.server.response.body.size.

Merge requirement checklist

@trask trask force-pushed the rename-http-body-size-metrics branch from 2901149 to 6a1740b Compare August 13, 2023 21:18
@trask trask force-pushed the rename-http-body-size-metrics branch from 6a1740b to f48794d Compare August 13, 2023 21:20
@trask trask marked this pull request as ready for review August 13, 2023 21:21
@trask trask requested review from a team as code owners August 13, 2023 21:21
@reyang
Copy link
Member

reyang commented Aug 14, 2023

@trask need to resolve merge conflicts.

@trask trask force-pushed the rename-http-body-size-metrics branch from 44d706a to d0eed3f Compare September 20, 2023 22:40
@trask trask force-pushed the rename-http-body-size-metrics branch from d0eed3f to 26c0e51 Compare September 20, 2023 22:47
@trask trask force-pushed the rename-http-body-size-metrics branch from 41a20c5 to 311b219 Compare September 20, 2023 22:51
@arminru arminru merged commit 9db3c5f into open-telemetry:main Sep 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we rename http.(client|server).(request|response).size metrics?
7 participants