Add cluster.name and node.name attributes to Elasticsearch semantic conventions.
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joaopgrassi
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Hi @stevejgordon! Could please adapt the PR name to better indicate the addition of these two attributes to the Elasticsearch conventions?
Co-authored-by: Joao Grassi <joao@joaograssi.com>
stevejgordon
changed the title
cluster_name and cluster_instance attributes to Elasticsearch semantic conventions.
AlexanderWert
approved these changes
Aug 29, 2023
joaopgrassi
approved these changes
Aug 29, 2023
Co-authored-by: Joao Grassi <joao@joaograssi.com>
stevejgordon
changed the title
cluster_name and cluster_instance attributes to Elasticsearch semantic conventions.cluster.name and cluster.instance attributes to Elasticsearch semantic conventions.
stevejgordon
force-pushed
the
update-elasticsearch
branch
from
ec9a6bd
to
6441928
Compare
stevejgordon
changed the title
cluster.name and cluster.instance attributes to Elasticsearch semantic conventions.cluster.name and node.name attributes to Elasticsearch semantic conventions.
|
@joaopgrassi We've discussed internally and updated the naming of one of the attributes to better align with how this value is referred to in the general Elasticsearch documentation. Both are kept as namespaced to allow for possible future, non-breaking additions. |
joaopgrassi
reviewed
Sep 6, 2023
joaopgrassi
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces two new attributes recommended when they can be retrieved from response headers. It also reformats the introduction to align with the conventions used in most other db docs.
Merge requirement checklist