Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jvm.gc.duration histogram buckets to [ 0.01, 0.1, 1, 10 ] #317

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

trask
Copy link
Member

@trask trask commented Sep 12, 2023

Fixes #274

Related to #316

Changes

Updates jvm.gc.duration histogram buckets to [ 0.01, 0.1, 1, 10 ].

Merge requirement checklist

@trask trask force-pushed the jvm-gc-buckets branch 2 times, most recently from 1bf4bfa to 7c2f74a Compare September 12, 2023 20:12
@trask trask marked this pull request as ready for review September 12, 2023 20:12
@trask trask requested review from a team as code owners September 12, 2023 20:12
Copy link
Member

@jonatan-ivanov jonatan-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we could have more buckets than this (though users can configure this) but bucketing is hard and I hope we will get some user feedback.

@trask
Copy link
Member Author

trask commented Sep 12, 2023

I still think we could have more buckets than this (though users can configure this) but bucketing is hard and I hope we will get some user feedback.

are you thinking an additional bucket on the low/high end, or more intermediate buckets?

@jonatan-ivanov
Copy link
Member

Probably not on the high end, though will there be an implicit +inf bucket too?
But on the low end and in between might be useful not just to have more accurate picture when something is wrong but also when users change something and they are curious about its impact.

@trask trask marked this pull request as ready for review November 9, 2023 17:20
@trask
Copy link
Member Author

trask commented Nov 9, 2023

Discussed in Java SIG. Consensus is that [ 0.01, 0.1, 1, 10 ] is a reasonable minimal set of buckets (keeping processing, transmission and storage costs down), and users can always override based on their specific needs

@AlexanderWert AlexanderWert merged commit 55a6575 into open-telemetry:main Nov 13, 2023
9 checks passed
@trask trask deleted the jvm-gc-buckets branch November 13, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Should jvm.gc.duration histogram have any default buckets?
7 participants