Merging events domain and name

[patrickhousley]

Fixes #2994

Changes

Merging the domain and name fields for events and modifying language to refer to the first part of the name as namespace. This more closely aligns the semantic conventions of events with metrics as we have discussed during the events working group meeting.

The spec update pull request is here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

• CONTRIBUTING.md guidelines followed.
• CHANGELOG.md updated for non-trivial changes.
• schema-next.yaml updated with changes to existing conventions.

[breedx-splk]

Looks good to me, and matches what we talked about in the sig meeting. Do the protobuf definitions also need to change accordingly? Can we link to that work or create a follow-up issue? Thanks! 🙏🏻

[patrickhousley]

Looks good to me, and matches what we talked about in the sig meeting. Do the protobuf definitions also need to change accordingly? Can we link to that work or create a follow-up issue? Thanks! 🙏🏻

I don't see events in the protobuf definitions repo. I may be blind so could you drop me a link? If it's not there, we should get a ticket created to make the protobuf definition.

[tigrannajaryan]

The PR needs a description that explains why the change is made, the motivation and reasoning.

It links to issue #2994 which does not exist in this repo.

[tigrannajaryan]

I am temporarily blocking the PR to give time to @scheler as they requested: open-telemetry/opentelemetry-specification#2994 (comment)

@scheler please comment on how much time you think you need.

The work on this PR can continue, it is a temporary block to avoid premature merging.

Removing my block after confirming with @scheler

[patrickhousley]

We're at 5 approvals now, so I think we're getting close. Looks like there's a table issue right now @patrickhousley

File /spec/general/events.md contains a table that would be reformatted.
make: *** [Makefile:98: table-check] Error 1

I run make fix locally but it's like it's reverting changes to the files. I am not sure what the error is or what the fix is doing.

[patrickhousley]

@breedx-splk I believe we are good to go now.

My request to link to main branch was wrong

Unblocking

[joaopgrassi]

Please change the links to the spec repo to use the correct tag.

[joaopgrassi]

Looks good, but the PR does more things then it says in the description. It also adds the device prefix, which I couldn't find any decision or discussion about it in the comments (maybe I missed it?)

I saw this issue #548 which opens the discussion but also no conclusion. Since this has several approvals, is everyone OK with this change as well? Is everyone aware of this?

[AlexanderWert]

It also adds the device prefix, which I couldn't find any decision or discussion about it in the comments (maybe I missed it?)

@joaopgrassi Actually it does not add the device prefix, but for mobile merges the event.domain(which has the value device) into the event.name as a prefix. So, actually applies the general proposal to the only relevant, concrete use case so far.

I'd like to keep #548 separate from this PR, that would change the prefix from device to mobile in that case.