Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change network.protocol.name from opt-in to conditionally required #478

Conversation

trask
Copy link
Member

@trask trask commented Oct 31, 2023

Fixes #477

Changes

Changes network.protocol.name from opt-in to conditionally required.

Merge requirement checklist

@trask trask force-pushed the network-protocol-name-requirement-level branch 3 times, most recently from 68caf26 to cbe895d Compare October 31, 2023 14:01
@trask trask marked this pull request as ready for review October 31, 2023 14:02
@trask trask requested review from a team as code owners October 31, 2023 14:02
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexanderWert AlexanderWert merged commit 69d6d4f into open-telemetry:main Nov 1, 2023
9 checks passed
@trask trask deleted the network-protocol-name-requirement-level branch November 1, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Reconsider requirement level of network.protocol.name
6 participants