Remove misleading pluralization wording related to count metrics #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
fix-pluralization-guidance
branch
from
548669d
to
45c7827
Compare
trask
changed the title
3 tasks
joaopgrassi
reviewed
Nov 3, 2023
ChrsMark
reviewed
Nov 15, 2023
trask
commented
Nov 15, 2023
AlexanderWert
approved these changes
Nov 15, 2023
ChrsMark
approved these changes
Nov 15, 2023
jsuereth
approved these changes
Nov 16, 2023
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
…n-telemetry#488) Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #484 (comment)
Changes
Removes this text in the semconv:
Because that text predated the "namespace pluralization rule" added in #267 and is meant to only apply to the other pluralization rules (not the namespace pluralization rule).
This is confusing now (with the addition of #267), and I think the easiest fix is just to remove the text, since the heading just above it already mentions it:
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.