Add http.flavor and http.user_agent to list of deprecated attributes
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
add-deprecated-attrs
branch
from
ddce3dd
to
cd86d67
Compare
arminru
approved these changes
Nov 10, 2023
AlexanderWert
approved these changes
Nov 11, 2023
trisch-me
reviewed
Nov 13, 2023
| @@ -67,11 +67,24 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin | |||
| <!-- semconv attributes.http.deprecated(omit_requirement_level) --> | |||
| | Attribute | Type | Description | Examples | | |||
| |---|---|---|---| | |||
| | `http.flavor` | string | Deprecated, use `network.procol.name` instead. | `1.0` | | |||
There was a problem hiding this comment.
There is a misspelling procol instead of protocol
There was a problem hiding this comment.
thanks for catching this! I'll send a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From slack discussion: https://cloud-native.slack.com/archives/C041APFBYQP/p1699627498067499?thread_ts=1699574431.891249&cid=C041APFBYQP
Changes
Adds
http.flavorandhttp.user_agentto list of deprecated attributes.These were already deprecated in
v1.20.0and so didn't make it into the deprecated attributes list, but I think it's good to list them, and will help with instrumentations implementingOTEL_SEMCONV_STABILITY_OPT_INwho are upgrading from earlier semconv thanv1.20.0.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.