-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow url.path sanitization #676
Merged
lmolkova
merged 13 commits into
open-telemetry:main
from
klauco:allow-sanitizing-url-path
Mar 2, 2024
Merged
Allow url.path sanitization #676
lmolkova
merged 13 commits into
open-telemetry:main
from
klauco:allow-sanitizing-url-path
Mar 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hey @klauco I also do have questions about change you've proposed, but let's discuss it later |
lmolkova
reviewed
Jan 31, 2024
3 tasks
lmolkova
approved these changes
Feb 28, 2024
trask
approved these changes
Feb 28, 2024
joaopgrassi
approved these changes
Feb 29, 2024
@klauco can you please fix the conflicts? Thanks! |
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Currently, url.full can be sanitized, however the path part of the URL can't. This PR allows sanitization of url.path.
Changes
-url.path is explicitely allowed to be sanitized.
Merge requirement checklist