Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url.path sanitization #676

Merged
merged 13 commits into from
Mar 2, 2024

Conversation

klauco
Copy link
Contributor

@klauco klauco commented Jan 30, 2024

Fixes #
Currently, url.full can be sanitized, however the path part of the URL can't. This PR allows sanitization of url.path.

Changes

-url.path is explicitely allowed to be sanitized.

Merge requirement checklist

@klauco klauco requested review from a team as code owners January 30, 2024 11:17
Copy link

linux-foundation-easycla bot commented Jan 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@trisch-me
Copy link
Contributor

hey @klauco
first you need to sign CLA, as for the PR itself, md files are autogenerated, if you want to change content you need to change appropriate yaml file and then run make table-generation

I also do have questions about change you've proposed, but let's discuss it later

@klauco klauco requested a review from a team as a code owner February 1, 2024 07:50
.chloggen/allow-sanitizing-url-path.yaml Outdated Show resolved Hide resolved
@joaopgrassi
Copy link
Member

@klauco can you please fix the conflicts? Thanks!

@lmolkova lmolkova merged commit 44690f1 into open-telemetry:main Mar 2, 2024
10 checks passed
@lmolkova lmolkova mentioned this pull request Mar 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants