Skip to content

Commit

Permalink
webhint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
furknyavuz committed Sep 3, 2021
1 parent dc633c9 commit 093819d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div *ngIf="brand" [class.no-margin]="noMargin" [class]="brand" class="icon-data-block" fxLayout="row">
<i aria-hidden="true" [class]="'fab fa-' + brand + ' fa-lg fa-fw'"></i>
<a [target]="target" class="inline-a" href="{{urlPrefix}}/{{data}}">{{data}}</a>
<a [target]="target" class="inline-a" aria-label="url" href="{{urlPrefix}}/{{data}}">{{data}}</a>
</div>

<div *ngIf="solid" [class.fix-width]="fixWidth" [class.no-margin-icon]="noMarginIcon" [class.no-margin]="noMargin"
Expand All @@ -10,15 +10,16 @@
<p *ngIf="!isClickable && !isClickableWithinApp && !urlData">{{data}}</p>
<a *ngIf="isClickable" [class.inline-a]="highlight"
[href]="(data.startsWith('http://') || data.startsWith('https://')) ? data : urlPrefix + data"
[target]="target">
[target]="target" aria-label="url">
{{data}}
</a>
<a *ngIf="isClickableWithinApp" [class.inline-a]="highlight"
[routerLink]="(data.startsWith('http://') || data.startsWith('https://')) ? data : urlPrefix + data">
[routerLink]="(data.startsWith('http://') || data.startsWith('https://')) ? data : urlPrefix + data"
aria-label="url">
{{data}}
</a>
<a *ngIf="urlData && queryParams" [class.inline-a]="highlight"
[queryParams]="queryParams" [routerLink]="urlData">
[queryParams]="queryParams" [routerLink]="urlData" aria-label="url">
{{data}}
</a>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
<span>Open Template Hub</span>
</a>
<div class="footer-social">
<a [href]="environment.social.twitter.url + '/' + environmentCommon.oth.social.twitter" target="_blank">
<a [href]="environment.social.twitter.url + '/' + environmentCommon.oth.social.twitter" target="_blank"
aria-label="twitter">
<i aria-hidden="true" [style.color]="option.style.themeColor" [class]="'fab fa-' + environment.social.twitter.cssClass + ' fa-2x fa-fw'"></i>
</a>
<a [href]="environment.social.linkedin.url + '/company/' + environmentCommon.oth.social.linkedin"
target="_blank">
target="_blank" aria-label="linkedin">
<i aria-hidden="true" [style.color]="option.style.themeColor" [class]="'fab fa-' + environment.social.linkedin.cssClass + ' fa-2x fa-fw'"></i>
</a>
</div>
Expand Down
9 changes: 5 additions & 4 deletions src/app/component/nav/common/footer/footer.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,20 @@
<h2>Open Template Hub <span class="copyright">&#169; 2021</span></h2>
</a>
<div class="footer-social">
<a [href]="environment.social.twitter.url + '/' + environmentCommon.oth.social.twitter" target="_blank" rel=noopener>
<a [href]="environment.social.twitter.url + '/' + environmentCommon.oth.social.twitter" target="_blank"
rel=noopener aria-label="twitter">
<i aria-hidden="true" [class]="'fab fa-' + environment.social.twitter.cssClass + ' fa-2x fa-fw'"></i>
</a>
<a [href]="'https://github.com/' + environmentCommon.oth.social.github"
target="_blank" rel=noopener>
target="_blank" rel=noopener aria-label="github">
<i aria-hidden="true" [class]="'fab fa-' + environment.social.github.cssClass + ' fa-2x fa-fw'"></i>
</a>
<a [href]="'https://www.producthunt.com/' + environmentCommon.oth.social.productHunt"
target="_blank" rel=noopener>
target="_blank" rel=noopener aria-label="producthunt">
<i aria-hidden="true" [class]="'fab fa-' + environment.social.productHunt.cssClass + ' fa-2x fa-fw'"></i>
</a>
<a [href]="environment.social.linkedin.url + '/company/' + environmentCommon.oth.social.linkedin"
target="_blank" rel=noopener>
target="_blank" rel=noopener aria-label="linkedin">
<i aria-hidden="true" [class]="'fab fa-' + environment.social.linkedin.cssClass + ' fa-2x fa-fw'"></i>
</a>
</div>
Expand Down

0 comments on commit 093819d

Please sign in to comment.