Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KENG artifacts renaming, plus introduction of the license server #61

Merged
merged 56 commits into from
Nov 2, 2023

Conversation

bortok
Copy link
Collaborator

@bortok bortok commented Oct 11, 2023

We have three categories of changes, and they are interconnected, so bundling them all together:

  • Aligning names of some artifacts with the official product name “Keysight Elastic Network Generator”,
  • Introducing licensing enforcement for advanced capabilities of “Keysight Elastic Network Generator”,
  • Changing docker image path and access for some artifacts enabled by the licensing enforcement.
Old name New name
ixia-c-controller keng-controller
ixia-c-operator keng-operator
ixia-c-ixhw-server keng-layer23-hw-server
ixia-c-app-usage-reporter keng-app-usage-reporter
ixia-c-gnmi-server otg-gnmi-server

Ixia-c name becomes tied only to the type of the KENG Test Ports that are container-based SW, as opposed to L23 Hardware or UHD400T.

The changes related to the licensing:

  • LICENSE-SERVERS env var for keng-controller supplied via docker-compose YAML for HW or keng-operator for KNE setups
  • Configmap for the keng-operator to provide a value for the LICENSE-SERVERS
  • License Server VM is needed with a valid license

We’re changing visibility of some previously private images to become public, and therefore their docker image paths are changing as well:

Old private path New public path
ghcr.io/open-traffic-generator/licensed/ixia-c-controller ghcr.io/open-traffic-generator/keng-controller
ghcr.io/open-traffic-generator/licensed/ixia-c-protocol-engine ghcr.io/open-traffic-generator/ixia-c-protocol-engine
ghcr.io/open-traffic-generator/ixia-c-ixhw-server ghcr.io/open-traffic-generator/keng-layer23-hw-server

@bortok bortok marked this pull request as draft October 11, 2023 05:32
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@@ -1,2 +1,2 @@
snappi==0.11.6
snappi==0.12.6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if fails with 0.13

snappi==0.12.6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if works with 0.13

hybrid/fp-b2b/Makefile Outdated Show resolved Hide resolved
snappi==0.12.6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if 0.13 works

@bortok bortok marked this pull request as ready for review November 2, 2023 04:07
@bortok bortok merged commit b7174c9 into main Nov 2, 2023
11 checks passed
@bortok bortok deleted the keng-renaming branch November 2, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant