Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container lab static lag fix #68

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Container lab static lag fix #68

merged 7 commits into from
Mar 20, 2024

Conversation

indraniBh
Copy link
Contributor

No description provided.

Copy link
Contributor

@apratimmukherjee apratimmukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also variate the dest IP

clab/ixia-c-b2b-lag/otg.yaml Show resolved Hide resolved
@apratimmukherjee
Copy link
Contributor

@bortok : Might be good to also add expectation from the test in the description of the test maybe or as a log when user runs the test . Assuming it is not so easy to actually validate that packets are hashed across ports and tx=rx in this example.

indraniBh and others added 2 commits March 20, 2024 11:24
Variate dest IP to validate IP get actual hashing.
@bortok
Copy link
Collaborator

bortok commented Mar 20, 2024

@apratimmukherjee if you could updated readme on the expectations subject, that would be great

@apratimmukherjee
Copy link
Contributor

apratimmukherjee commented Mar 20, 2024

@apratimmukherjee if you could updated readme on the expectations subject, that would be great

@bortok : I have attempted to add the expectations for flow and port stats in the README based on observations when debugging the issue with Indrani. However, I have not set it up and executed it myself to confirm that this is all working with final set of changes.

@bortok bortok merged commit 9ef075f into main Mar 20, 2024
11 checks passed
@bortok bortok deleted the clab-lag-fix branch March 20, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants