Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OTN member profiles and map #3

Closed
jhpoelen opened this issue Aug 22, 2019 · 11 comments
Closed

add OTN member profiles and map #3

jhpoelen opened this issue Aug 22, 2019 · 11 comments
Assignees

Comments

@jhpoelen
Copy link
Member

as suggested by @iimog -

use something similar to this: https://www.de-rse.org/en/map.html which
is fed by a simple js file:
https://github.com/DE-RSE/www/blob/gh-pages/_includes/mapdata.js
including name, image, testimonial, ...
@jhpoelen
Copy link
Member Author

Also, @caterinap mentioned to use existing google spreadsheet to populate profiles from co-author list.

@jhpoelen jhpoelen changed the title add OTN profiles and map add OTN member profiles and map Aug 22, 2019
@iimog iimog self-assigned this Aug 23, 2019
@iimog
Copy link
Member

iimog commented Aug 23, 2019

I have a working version of the map in a local clone. It is not populated with the OTN members, yet and the design needs a little polishing. I guess adding the authors from the spreadsheet is easier than having everyone add themselves but it is probably quite some manual work as the locations have to be mapped to coordinates. I'll let you know as soon as I have something you can look at.

@rachaelgallagher
Copy link
Contributor

rachaelgallagher commented Aug 25, 2019 via email

@rachaelgallagher
Copy link
Contributor

rachaelgallagher commented Aug 26, 2019

@silviapine is going to compile the lat-long coordinates for us @iimog. Thanks Silvia!

@silviapine
Copy link
Contributor

silviapine commented Aug 26, 2019 via email

@jhpoelen
Copy link
Member Author

jhpoelen commented Aug 28, 2019

I've added placeholders for member entries at https://github.com/open-traits-network/open-traits-network.github.io/tree/master/_members . Also, I've created a placeholder member list page at https://github.com/open-traits-network/open-traits-network.github.io/tree/master/members.md which can be reached at https://opentraits.org/members .

I hope that others can help:

  • come up with minimal meta data elements for member registration
  • apply style of member pages and list
  • populate the member pages
  • add instructions on how to maintain member registry

@iimog
Copy link
Member

iimog commented Aug 28, 2019

In my fork I populated the _members with the authors of the OTN manuscript thanks to the help of @silviapine. I extracted name, affiliation, longitute and latitute (only the first affiliation and coordinates for each author). I also used this information to populate the OTN member map prototype. As a show-case I also populated for my own profile the fields: image, homepage and info which is also used in the OTN map (you can find my pin in Würzburg, Germany). Let me know what you think. I can create a pr anytime. The map uses leaflet.js to work (currently copied to the repo but we can use a CDN instead).

@jhpoelen
Copy link
Member Author

@iimog @silviapine wow that was fast! I've created a screenshot of your profile (see attached) on the map just to show off your work ; )

Screenshot from 2019-08-28 07-04-56

Some things/ideas that came to mind as I was poking around :

  • should we reuse github profile photo's when none are explicitly provided? E.g., https://github.com/iimog.png?size=128
  • for some reason, the special characters for Hervé Sauquet looked like Herv&eaccute; Sauquet in the link
  • would it be an idea to somehow combine or link a list view with the map view ? This way you can navigate by location and by name .
  • could you add some instructions to the README.md with example? I hope that this would help our future selves and others to update / add members.

@bmaitner
Copy link
Contributor

Wow, @iimog and @silviapine , that looks fantastic! I was particularly impressed that the coordinates were pointed to the individual buildings on campus that we're in! A future nice to have (unless it's easy for you now) would be the ability to hide/show folks based on taxonomic expertise. Then we're at the point where folks can easily look for collaborators in another part of the world :)

@iimog
Copy link
Member

iimog commented Aug 30, 2019

I'm happy that you like it so far. I continued a little bit:

  • I fixed the special character problem for Hervé (a typo: &eaccute; -> é)
  • I use profile pictures from github if no picture is provided but the github account name is (I added this info for all participants in this issue). It loads a little slower but it works.
  • I also added preliminary documentation to the README file. All information for the map is extracted from the yml header in the _members files. I introduced some fields that I thought useful but we can add others without problem (also without breaking anything).
  • I can easily create a table view from the _members files as well, we only need to decide what info to show and design things (like where that table should be located and how it should look like). And also if it should have additional functionality like zooming to the pin of the person when clicked in the table.
  • I really like the suggestion to filter the map by taxonomic expertise and I have an idea on how to implement it. But I think we need to discuss how we want to handle this information in general: does every member need to add a taxonomic expertise, do we restrict it to predefined values, can members be experts in multiple groups, etc. If we decide on exactly one group out of a predefined set for every member we could also use distinct pins with specific icons in addition to the filtering.

I'll open a pull request with my work so far to make it easier for others to see what I did and to add to it.

@jhpoelen
Copy link
Member Author

jhpoelen commented Aug 30, 2019

@iimog Nice - thanks for taking the first stab at this! I took the liberty to merge to pull requests so that others can more easily enjoy your work at https://opentraits.org/members and https://opentraits.org/map . Am closing this issue and suggest to open new individual issues for improvements on the member list and member map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants