Skip to content

Commit

Permalink
chore: add decorators transform for addon consumers (#85)
Browse files Browse the repository at this point in the history
* Add decorators transform for addon consumers

Per the warning ember-decorators throws (text below), the babel-transform addon needs to be installed in order to use ember-decorators. 
```
WARNING: ember-decorators (used in ember-bulma): You have not installed @ember-decorators/babel-transforms. It has been extracted to a separate addon. See instructions for installation: https://github.com/ember-decorators/babel-transforms#readme
```

* fix: update babel-eslint to fix build issue

eslint/eslint#9767 (comment)

* fix: require sudo for headless chrome build tests

travis-ci/travis-ci#8836 (comment)
  • Loading branch information
Michael Head authored and crodriguez1a committed Mar 7, 2018
1 parent c207417 commit 3065b51
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ node_js:
# so that your addon works for all apps
- "4"

sudo: false
sudo: required
dist: trusty

addons:
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
}
},
"dependencies": {
"babel-eslint": "^7.2.3",
"@ember-decorators/babel-transforms": "^2.0.0",
"babel-eslint": "^8.1.1",
"broccoli-funnel": "^1.2.0",
"ember-cli-babel": "^6.6.0",
"ember-cli-htmlbars": "^2.0.1",
Expand Down

2 comments on commit 3065b51

@jlegrone
Copy link
Contributor

@jlegrone jlegrone commented on 3065b51 Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crodriguez1a @alexdiliberto please keep in mind that semantic-release will not publish new package versions if we use the chore commit type. See travis output for the build triggered by this commit:

https://travis-ci.org/open-tux/ember-bulma/jobs/350491797#L845

I recommend a merge-only strategy when accepting pull requests that contain valid conventional commits, as this ensures we generate complete release notes, document breaking changes, and increment version numbers as indicated by the pull request author.

@crodriguez1a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlegrone This is my fault. I've been away from the project since about the time when we still had manual releases. I'll have to re-acclimate.

Please sign in to comment.