Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend 'Add Erlang LS extension (#213)' #217

Merged
merged 3 commits into from Nov 23, 2020
Merged

Amend 'Add Erlang LS extension (#213)' #217

merged 3 commits into from Nov 23, 2020

Conversation

chintan-mishra
Copy link
Contributor

No description provided.

@chintan-mishra
Copy link
Contributor Author

The name of ErlangLS plugin are of the following format: erlang-ls-0.0.15.vsix. I have directed the auto-publishing tool to use the wildcard filename whenever a new .vsix file is built. In order to do this, I have used extensionFile: erlang-ls-*.vsix in the section defining this tool. What are the possible ramifications of this step?

@chintan-mishra chintan-mishra mentioned this pull request Nov 13, 2020
Merged
jankeromnes
jankeromnes reviewed Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@jankeromnes jankeromnes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chintan-mishra Thanks for improving the auto-publishing of the Erlang LS extension!

I've added a few thoughts & questions below.

extensions.json Outdated Show resolved Hide resolved
extensions.json Outdated Show resolved Hide resolved
extensions.json Outdated Show resolved Hide resolved
@jankeromnes jankeromnes mentioned this pull request Nov 20, 2020
Closed
jankeromnes
jankeromnes approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, many thanks! 💯 🙏

@jankeromnes jankeromnes merged commit ab3bf6f into open-vsx:master Nov 23, 2020
tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
@chintan-mishra
Amend 'Add Erlang LS extension (open-vsx#213)' (open-vsx#217)
6ccc1d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chintan-mishra @jankeromnes