Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tomoki1207.pdf #560

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Add tomoki1207.pdf #560

merged 1 commit into from
Mar 19, 2022

Conversation

greyscaled
Copy link
Contributor

👋, To the best of my knowledge, I'm following etiquette for getting https://github.com/tomoki1207/vscode-pdfviewer into Open VSX.

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to OpenVSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR introduces adding tomoki1207.pdf change to add it to Open VSX. The extension does not seem unmaintained, but the issue for adding it to OpenVSX has not been responded to: tomoki1207/vscode-pdfviewer#89.

Copy link
Collaborator

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR ✅

@filiptronicek filiptronicek added the extension Regarding an extension label Mar 19, 2022
@filiptronicek filiptronicek merged commit 7dab286 into open-vsx:master Mar 19, 2022
@greyscaled greyscaled deleted the patch-1 branch March 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Regarding an extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants