Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analyzer] Broken manifest with new decorator standard "accessor" keyword #243

Closed
brian-patrick-3 opened this issue Mar 19, 2024 · 4 comments

Comments

@brian-patrick-3
Copy link

brian-patrick-3 commented Mar 19, 2024

Since upgrading to Lit 3.x and migrating all of our decorators to the new standard which requires the accessor keyword in front, the analyzer is unable to build my manifest properly. This is problematic because now a bunch of private properties marked @internal or @ignore are now showing up in our Storybook docs. Ex:

  /** Some private property.
   * @internal
   */
  @state()
  accessor _prop!: string;
@thepassle
Copy link
Member

Whats the problem? Do you see any errors? Or it just doesnt output the properties?

@thepassle
Copy link
Member

I see what's happening. The version of ts that the analyzer uses doesn't support the accessor keyword yet (it was introduced in 4.9.0). Updating the ts version to 4.9.0 breaks a bunch of tests, because apparently they changed the way how decorators are represented in the AST, so this will take a little bit of reworking. Ill try to take a stab at it this week, or feel free to create a PR if you need it sooner :)

@thepassle
Copy link
Member

Ive updated the internally used TS version to 5.4.2, so I expect that this will be fixed in that version. I released it as 0.9.4. Please feel free to reopen if the issue persists :)

@brian-patrick-3
Copy link
Author

@thepassle Thank you so much, saved me a lot of headache this morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants