Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "@attribute" in "PropertyDeclarations" and in Constructor bodies #252

Merged
merged 3 commits into from
May 7, 2024
Merged

Add support for "@attribute" in "PropertyDeclarations" and in Constructor bodies #252

merged 3 commits into from
May 7, 2024

Conversation

KonnorRogers
Copy link
Contributor

@KonnorRogers KonnorRogers commented May 6, 2024 •
edited
Loading

Fixes #250 and #251

@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited
Loading

✅ Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
🔨 Latest commit 0110361
🔍 Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/66393c98c7748c0008dd3100
😎 Deploy Preview https://deploy-preview-252--custom-elements-manifest-analyzer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KonnorRogers KonnorRogers changed the title Add support for "@attribute" Add support for "@attribute" when using in a class body, but not in class constructor May 6, 2024
@KonnorRogers KonnorRogers changed the title Add support for "@attribute" when using in a class body, but not in class constructor Add support for "@attribute" in "PropertyDeclarations" May 6, 2024
@KonnorRogers KonnorRogers changed the title Add support for "@attribute" in "PropertyDeclarations" Add support for "@attribute" in "PropertyDeclarations" and in Constructor bodies May 6, 2024
@thepassle
Copy link
Member

LGTM, can you add a testcase in packages/analyzer/fixtures/06-jsdoc/default/package/my-element.js? fixture/custom-elements.json is the expected state, and output.json is what CEM/A outputs, so you should update fixture/custom-elements.json manually with the changes. Lemme know if you need any help or if its unclear :)

@KonnorRogers
Copy link
Contributor Author

@thepassle added!

@thepassle thepassle merged commit 7029066 into open-wc:master May 7, 2024
5 checks passed
@thepassle
Copy link
Member

Thanks for the PR :) Released in 0.9.9

@thepassle thepassle mentioned this pull request May 7, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@attribute is not added to "attributes"
2 participants
@KonnorRogers @thepassle