-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analyzer): ignore and internal jsdoc #89
Conversation
It's likely i missed some test cases so please look over custom-elements-manifest/packages/analyzer/fixtures/jsdoc-ignore-internal/package/my-element.js Lines 1 to 38 in 6bd90a4
|
❌ Deploy Preview for custom-elements-manifest-analyzer failed. 🔨 Explore the source changes: cafb94d 🔍 Inspect the deploy log: https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/60eab3f0b0a21f0008810cd5 |
3c12b0f
to
6bd90a4
Compare
we already had an open PR for this that was almost finished here #22 |
6bd90a4
to
cafb94d
Compare
Ok I covered the case from #22 (comment) as well |
I think this is ready to go can you check the test cases please? |
Maybe we should revisit the approach we had in this PR #22, it solved like 99% of the cases with like 5 lines of code. The only case that needed to be fixed was: class MyEl extends HTMLElement {
priv2;
constructor() {
super();
/** @ignore */
this.priv2 = 'hidden';
}
} |
Unfortunately the previous PR, though brief, did not cover nearly enough cases to be useful, which is why I closed the previous in favour of this one. The reason this PR has to touch so many files is because in many of the handlers, there's no way to remove the |
Those test failures dont seem correct? The implementation in the other branch correctly excluded variables, classes, fields. You're correct that it didnt handle |
ok i'll give it another look maybe we can have it all |
fixes #21