fix(eslint-config): fix peer dependency mismatch (#2477)

* fix(eslint-config): fix peer dependency mismatch * fix linting issues * update changeset Co-authored-by: Pascal Schilp <pascalschilp@gmail.com>
open-wc · Aug 3, 2022 · 61e2668 · 61e2668
1 parent a8bc80e
commit 61e2668
Show file tree

Hide file tree

Showing 79 changed files with 587 additions and 378 deletions.
diff --git a/.changeset/purple-ears-own.md b/.changeset/purple-ears-own.md
@@ -0,0 +1,13 @@
+---
+'@open-wc/building-rollup': patch
+'@open-wc/building-utils': patch
+'@open-wc/codelabs': patch
+'@open-wc/dev-server-hmr': patch
+'@open-wc/eslint-config': patch
+'eslint-plugin-lit-a11y': patch
+'@open-wc/scoped-elements': patch
+'storybook-addon-markdown-docs': patch
+'@open-wc/testing-helpers': patch
+---
+
+update eslint, eslint-config-airbnb-base and eslint-plugin-import
diff --git a/package.json b/package.json
@@ -74,11 +74,11 @@
     "concurrently": "^6.0.2",
     "copyfiles": "^2.4.1",
     "core-js": "^3.11.1",
-    "eslint": "^7.6.0",
-    "eslint-config-airbnb-base": "^14.2.1",
+    "eslint": "^8.21.0",
+    "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-html": "^6.1.2",
-    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-no-only-tests": "^2.6.0",
     "eslint-plugin-wc": "^1.3.0",
     "fs-extra": "^10.0.0",

diff --git a/packages/building-rollup/index.js b/packages/building-rollup/index.js
@@ -3,8 +3,8 @@
  * @typedef {import('./src/types').SpaOptions} SpaOptions
  */
 
-const { createBasicConfig } = require('./src/createBasicConfig');
-const { createSpaConfig } = require('./src/createSpaConfig');
-const { createMpaConfig } = require('./src/createMpaConfig');
+const { createBasicConfig } = require('./src/createBasicConfig.js');
+const { createSpaConfig } = require('./src/createSpaConfig.js');
+const { createMpaConfig } = require('./src/createMpaConfig.js');
 
 module.exports = { createBasicConfig, createSpaConfig, createMpaConfig };
diff --git a/packages/building-rollup/src/babel/babel-configs.js b/packages/building-rollup/src/babel/babel-configs.js
@@ -1,5 +1,5 @@
-const { babelPluginBundledHelpers } = require('./babel-plugin-bundled-helpers');
-const { isFalsy } = require('../utils');
+const { babelPluginBundledHelpers } = require('./babel-plugin-bundled-helpers.js');
+const { isFalsy } = require('../utils.js');
 
 const createBabelConfigRollupBuild = ({ developmentMode }) => ({
   babelHelpers: 'bundled',

diff --git a/packages/building-rollup/src/babel/babel-plugin-bundled-helpers.js b/packages/building-rollup/src/babel/babel-plugin-bundled-helpers.js
@@ -1,5 +1,5 @@
 const { types } = require('@babel/core');
-const { HELPER_MODULE_NAME } = require('./rollup-plugin-bundled-babel-helpers');
+const { HELPER_MODULE_NAME } = require('./rollup-plugin-bundled-babel-helpers.js');
 
 /**
  * Babel plugin which imports babel helpers from a helper module.

diff --git a/packages/building-rollup/src/createBasicConfig.js b/packages/building-rollup/src/createBasicConfig.js
@@ -9,9 +9,9 @@ const {
   createBabelConfigRollupBuild,
   babelConfigLegacyRollupGenerate,
   babelConfigSystemJs,
-} = require('./babel/babel-configs');
-const { bundledBabelHelpers } = require('./babel/rollup-plugin-bundled-babel-helpers');
-const { isFalsy, pluginWithOptions, dedupedBabelPlugin } = require('./utils');
+} = require('./babel/babel-configs.js');
+const { bundledBabelHelpers } = require('./babel/rollup-plugin-bundled-babel-helpers.js');
+const { isFalsy, pluginWithOptions, dedupedBabelPlugin } = require('./utils.js');
 
 /**
  * @param {BasicOptions} userOptions

diff --git a/packages/building-rollup/src/createSpaConfig.js b/packages/building-rollup/src/createSpaConfig.js
@@ -8,9 +8,9 @@ const { importMetaAssets } = require('@web/rollup-plugin-import-meta-assets');
 const { polyfillsLoader } = require('@web/rollup-plugin-polyfills-loader');
 const path = require('path');
 const { generateSW } = require('rollup-plugin-workbox');
-const { createBasicConfig } = require('./createBasicConfig');
-const { pluginWithOptions, applyServiceWorkerRegistration, isFalsy } = require('./utils');
-const { defaultPolyfills } = require('./polyfills');
+const { createBasicConfig } = require('./createBasicConfig.js');
+const { pluginWithOptions, applyServiceWorkerRegistration, isFalsy } = require('./utils.js');
+const { defaultPolyfills } = require('./polyfills.js');
 
 /**
  * @param {SpaOptions} options

diff --git a/packages/building-utils/dom5-utils.js b/packages/building-utils/dom5-utils.js
@@ -11,7 +11,7 @@ const {
   predicates,
   getAttribute,
   hasAttribute,
-} = require('./dom5-fork');
+} = require('./dom5-fork/index.js');
 
 /**
  * @param {string} tag

diff --git a/packages/building-utils/index-html/create-index-html.js b/packages/building-utils/index-html/create-index-html.js
@@ -1,12 +1,12 @@
 const { serialize } = require('parse5');
 const path = require('path');
 const deepmerge = require('deepmerge');
-const { createScript, createElement } = require('../dom5-utils');
-const { append, insertBefore, query, predicates } = require('../dom5-fork');
-const { getPolyfills } = require('./polyfills');
-const { createLoaderScript } = require('./loader-script');
-const { minifyIndexHTML, defaultMinifyHTMLConfig } = require('./minify-index-html');
-const { createContentHash, cleanImportPath, polyfillFilename } = require('./utils');
+const { createScript, createElement } = require('../dom5-utils.js');
+const { append, insertBefore, query, predicates } = require('../dom5-fork/index.js');
+const { getPolyfills } = require('./polyfills.js');
+const { createLoaderScript } = require('./loader-script.js');
+const { minifyIndexHTML, defaultMinifyHTMLConfig } = require('./minify-index-html.js');
+const { createContentHash, cleanImportPath, polyfillFilename } = require('./utils.js');
 
 /** @typedef {import('parse5').Document} ASTNode */
 

diff --git a/packages/building-utils/index-html/extract-resources.js b/packages/building-utils/index-html/extract-resources.js
@@ -1,6 +1,6 @@
 const { parse } = require('parse5');
 const { isUri } = require('valid-url');
-const { queryAll, predicates, getAttribute, remove } = require('../dom5-fork');
+const { queryAll, predicates, getAttribute, remove } = require('../dom5-fork/index.js');
 
 /**
  * @typedef {object} ExtractResult

diff --git a/packages/building-utils/index-html/index.js b/packages/building-utils/index-html/index.js
@@ -1,7 +1,7 @@
-const { createIndexHTML } = require('./create-index-html');
-const { minifyIndexHTML } = require('./minify-index-html');
-const { extractResources } = require('./extract-resources');
-const { findInlineEntryId } = require('./inline-entry');
+const { createIndexHTML } = require('./create-index-html.js');
+const { minifyIndexHTML } = require('./minify-index-html.js');
+const { extractResources } = require('./extract-resources.js');
+const { findInlineEntryId } = require('./inline-entry.js');
 
 module.exports = {
   createIndexHTML,

diff --git a/packages/building-utils/index-html/loader-script.js b/packages/building-utils/index-html/loader-script.js
@@ -1,5 +1,5 @@
 const Terser = require('terser');
-const { cleanImportPath, polyfillFilename } = require('./utils');
+const { cleanImportPath, polyfillFilename } = require('./utils.js');
 
 /**
  * @typedef {import('./create-index-html').EntriesConfig} EntriesConfig

diff --git a/packages/building-utils/index-html/polyfills.js b/packages/building-utils/index-html/polyfills.js
@@ -1,7 +1,7 @@
 const path = require('path');
 const fs = require('fs');
 const Terser = require('terser');
-const { createContentHash } = require('./utils');
+const { createContentHash } = require('./utils.js');
 
 /** @typedef {import('./create-index-html').PolyfillInstruction} PolyfillInstruction */
 /** @typedef {import('./create-index-html').CreateIndexHTMLConfig} CreateIndexHTMLConfig */

diff --git a/packages/building-utils/index.js b/packages/building-utils/index.js
@@ -1,8 +1,8 @@
-const findSupportedBrowsers = require('./find-supported-browsers');
-const defaultFileExtensions = require('./default-file-extensions');
-const { toBrowserPath } = require('./to-browser-path');
-const { toFilePath } = require('./to-file-path');
-const dom5Utils = require('./dom5-utils');
+const findSupportedBrowsers = require('./find-supported-browsers.js');
+const defaultFileExtensions = require('./default-file-extensions.js');
+const { toBrowserPath } = require('./to-browser-path.js');
+const { toFilePath } = require('./to-file-path.js');
+const dom5Utils = require('./dom5-utils.js');
 
 module.exports = {
   findSupportedBrowsers,

diff --git a/packages/building-utils/test-node/dom5-utils.test.js b/packages/building-utils/test-node/dom5-utils.test.js
@@ -1,7 +1,7 @@
 const { expect } = require('chai');
 const { parse } = require('parse5');
-const { getAttribute, getTextContent } = require('../dom5-fork');
-const { findJsScripts, findImportMapScripts } = require('../dom5-utils');
+const { getAttribute, getTextContent } = require('../dom5-fork/index.js');
+const { findJsScripts, findImportMapScripts } = require('../dom5-utils.js');
 
 const htmlString = `
   <html>

diff --git a/packages/building-utils/test-node/index-html/extract-resources.test.js b/packages/building-utils/test-node/index-html/extract-resources.test.js
@@ -1,6 +1,6 @@
 const { expect } = require('chai');
-const { extractResources } = require('../../index-html');
-const { getAttribute, queryAll, predicates } = require('../../dom5-fork');
+const { extractResources } = require('../../index-html/index.js');
+const { getAttribute, queryAll, predicates } = require('../../dom5-fork/index.js');
 
 describe('extract-resources', () => {
   it('returns any resources found', () => {

diff --git a/packages/building-utils/test-node/index-html/generate-index-html.test.js b/packages/building-utils/test-node/index-html/generate-index-html.test.js
@@ -2,7 +2,7 @@ const { expect } = require('chai');
 const { parse } = require('parse5');
 const path = require('path');
 const fs = require('fs');
-const { createIndexHTML } = require('../../index-html');
+const { createIndexHTML } = require('../../index-html/index.js');
 
 const updateSnapshots = process.argv.includes('--update-snapshots');
 

diff --git a/packages/building-utils/test-node/index-html/loader-script.test.js b/packages/building-utils/test-node/index-html/loader-script.test.js
@@ -1,7 +1,7 @@
 const { expect } = require('chai');
 const fs = require('fs');
 const path = require('path');
-const { createLoaderScript } = require('../../index-html/loader-script');
+const { createLoaderScript } = require('../../index-html/loader-script.js');
 
 const updateSnapshots = process.argv.includes('--update-snapshots');
 

diff --git a/packages/building-utils/test-node/index-html/polyfills.test.js b/packages/building-utils/test-node/index-html/polyfills.test.js
@@ -1,6 +1,6 @@
 const path = require('path');
 const { expect } = require('chai');
-const { getPolyfills } = require('../../index-html/polyfills');
+const { getPolyfills } = require('../../index-html/polyfills.js');
 
 describe('polyfills', () => {
   it('returns the correct polyfills', () => {

diff --git a/packages/building-utils/to-file-path.js b/packages/building-utils/to-file-path.js
@@ -5,7 +5,7 @@ const path = require('path');
  * but it should use `/` in the browser.
  */
 function toFilePath(browserPath) {
-  return browserPath.replace(new RegExp('/', 'g'), path.sep);
+  return browserPath.replace(/\//g, path.sep);
 }
 
 module.exports = { toFilePath };
diff --git a/packages/codelabs/build-codelabs.js b/packages/codelabs/build-codelabs.js
@@ -3,7 +3,7 @@ const fs = require('fs-extra');
 const path = require('path');
 const markedSync = require('marked');
 const cheerio = require('cheerio');
-const createCodelabIndex = require('./createCodelabIndex');
+const createCodelabIndex = require('./createCodelabIndex.js');
 
 const outputDir = path.join(__dirname, '..', '..', '_site', 'codelabs');
 

diff --git a/packages/dev-server-hmr/src/babel/babelPluginWcHmr.js b/packages/dev-server-hmr/src/babel/babelPluginWcHmr.js
@@ -32,19 +32,19 @@
 
 const path = require('path');
 
-const { findDefinedCustomElement } = require('./customElementsDefine');
-const { findDecoratedCustomElement } = require('./decorators');
+const { findDefinedCustomElement } = require('./customElementsDefine.js');
+const { findDecoratedCustomElement } = require('./decorators.js');
 const {
   injectRegisterClass,
   injectRuntime,
   isClassRegistered,
   findComponentName,
-} = require('./inject');
-const { parseOptions, singlePath, addToSet } = require('./utils');
-const { isFunctionComponent } = require('./functions');
-const { getImportedVariableNames } = require('./getImportedVariableNames');
-const { implementsBaseClass } = require('./class');
-const { createError } = require('../utils');
+} = require('./inject.js');
+const { parseOptions, singlePath, addToSet } = require('./utils.js');
+const { isFunctionComponent } = require('./functions.js');
+const { getImportedVariableNames } = require('./getImportedVariableNames.js');
+const { implementsBaseClass } = require('./class.js');
+const { createError } = require('../utils.js');
 
 /** @returns {PluginObj} */
 function babelPluginWcHmr() {

diff --git a/packages/dev-server-hmr/src/babel/babelTransform.js b/packages/dev-server-hmr/src/babel/babelTransform.js
@@ -1,7 +1,7 @@
 const { transformAsync } = require('@babel/core');
 
-const babelPluginWcHmr = require('./babelPluginWcHmr');
-const { createError } = require('../utils');
+const babelPluginWcHmr = require('./babelPluginWcHmr.js');
+const { createError } = require('../utils.js');
 
 /** @typedef {import('./babelPluginWcHmr').BabelPluginWcHmrOptions} BabelPluginWcHmrOptions */
 

diff --git a/packages/dev-server-hmr/src/babel/class.js b/packages/dev-server-hmr/src/babel/class.js
@@ -2,7 +2,7 @@
 /** @typedef {import('@babel/types').ClassExpression} ClassExpression */
 /** @template T @typedef {import('@babel/core').NodePath<T>} NodePath<T> */
 
-const { singlePath } = require('./utils');
+const { singlePath } = require('./utils.js');
 
 /**
  * @param {NodePath<ClassDeclaration> | NodePath<ClassExpression>} classDeclOrExpr

diff --git a/packages/dev-server-hmr/src/babel/customElementsDefine.js b/packages/dev-server-hmr/src/babel/customElementsDefine.js
@@ -5,7 +5,7 @@
 /** @typedef {import('@babel/types').Expression} Expression */
 /** @template T @typedef {import('@babel/core').NodePath<T>} NodePath<T> */
 
-const { resolvePath, findComponentDefinition, singlePath } = require('./utils');
+const { resolvePath, findComponentDefinition, singlePath } = require('./utils.js');
 
 const GLOBALS = ['window', 'self', 'globalThis'];
 

diff --git a/packages/dev-server-hmr/src/babel/decorators.js b/packages/dev-server-hmr/src/babel/decorators.js
@@ -2,7 +2,7 @@
 /** @typedef {import('./babelPluginWcHmr').Decorator} Decorator */
 /** @template T @typedef {import('@babel/core').NodePath<T>} NodePath<T> */
 
-const { findComponentDefinition, singlePath } = require('./utils');
+const { findComponentDefinition, singlePath } = require('./utils.js');
 
 /**
  * @param {Set<string>} decoratorNames

diff --git a/packages/dev-server-hmr/src/babel/functions.js b/packages/dev-server-hmr/src/babel/functions.js
@@ -4,7 +4,7 @@
 /** @typedef {import('./babelPluginWcHmr').Decorator} Decorator */
 /** @template T @typedef {import('@babel/core').NodePath<T>} NodePath<T> */
 
-const { singlePath } = require('./utils');
+const { singlePath } = require('./utils.js');
 
 /**
  * @param {NodePath<CallExpression>} callExpr

diff --git a/packages/dev-server-hmr/src/babel/getImportedVariableNames.js b/packages/dev-server-hmr/src/babel/getImportedVariableNames.js
@@ -9,7 +9,7 @@
 /** @typedef {import('./babelPluginWcHmr').FunctionOption} FunctionOption */
 
 const path = require('path');
-const { singlePath } = require('./utils');
+const { singlePath } = require('./utils.js');
 
 /**
  * @param {string} importSpecifier

diff --git a/packages/dev-server-hmr/src/babel/inject.js b/packages/dev-server-hmr/src/babel/inject.js
@@ -6,8 +6,8 @@
 /** @template T @typedef {import('@babel/core').NodePath<T>} NodePath<T> */
 
 const { parse, types: t } = require('@babel/core');
-const { WC_HMR_NAMESPACE, WC_HMR_MODULE_PATCH, WC_HMR_MODULE_RUNTIME } = require('../constants');
-const { singlePath, parseStatement } = require('./utils');
+const { WC_HMR_NAMESPACE, WC_HMR_MODULE_PATCH, WC_HMR_MODULE_RUNTIME } = require('../constants.js');
+const { singlePath, parseStatement } = require('./utils.js');
 
 const REGISTER_FN_NAME = 'register';
 

diff --git a/packages/dev-server-hmr/src/babel/utils.js b/packages/dev-server-hmr/src/babel/utils.js
@@ -6,7 +6,7 @@
 /** @template T @typedef {import('@babel/core').NodePath<T>} NodePath<T> */
 
 const { parse } = require('@babel/core');
-const { createError } = require('../utils');
+const { createError } = require('../utils.js');
 
 /**
  * @param {BabelPluginWcHmrOptions} options

diff --git a/packages/dev-server-hmr/src/hmrPlugin.js b/packages/dev-server-hmr/src/hmrPlugin.js
@@ -42,9 +42,13 @@ const { hmrPlugin: createBaseHmrPlugin } = require('@web/dev-server-hmr');
 const fs = require('fs');
 const path = require('path');
 
-const { WC_HMR_MODULE_PREFIX, WC_HMR_MODULE_RUNTIME, WC_HMR_MODULE_PATCH } = require('./constants');
-const { parseConfig, createMatchers, createError } = require('./utils');
-const { babelTransform } = require('./babel/babelTransform');
+const {
+  WC_HMR_MODULE_PREFIX,
+  WC_HMR_MODULE_RUNTIME,
+  WC_HMR_MODULE_PATCH,
+} = require('./constants.js');
+const { parseConfig, createMatchers, createError } = require('./utils.js');
+const { babelTransform } = require('./babel/babelTransform.js');
 
 const wcHmrRuntime = fs.readFileSync(path.resolve(__dirname, 'wcHmrRuntime.js'), 'utf-8');
 

diff --git a/packages/dev-server-hmr/src/index.js b/packages/dev-server-hmr/src/index.js
@@ -1,9 +1,9 @@
-const { hmrPlugin } = require('./hmrPlugin');
-const { litElement } = require('./presets/litElement');
-const { lit } = require('./presets/lit');
-const { fastElement } = require('./presets/fastElement');
-const { haunted } = require('./presets/haunted');
-const { WC_HMR_MODULE_RUNTIME } = require('./constants');
+const { hmrPlugin } = require('./hmrPlugin.js');
+const { litElement } = require('./presets/litElement.js');
+const { lit } = require('./presets/lit.js');
+const { fastElement } = require('./presets/fastElement.js');
+const { haunted } = require('./presets/haunted.js');
+const { WC_HMR_MODULE_RUNTIME } = require('./constants.js');
 
 const presets = { litElement, fastElement, haunted, lit };
 

diff --git a/packages/dev-server-hmr/test-node/babel/base-class.test.js b/packages/dev-server-hmr/test-node/babel/base-class.test.js
@@ -1,7 +1,7 @@
 /* eslint-disable import/no-extraneous-dependencies */
 const { expect } = require('chai');
 const path = require('path');
-const { banner, transform, rootDir } = require('./utils');
+const { banner, transform, rootDir } = require('./utils.js');
 
 describe('babelPluginWcHmr - detecting base class', () => {
   it('global base class', () => {

diff --git a/packages/dev-server-hmr/test-node/babel/customElements.test.js b/packages/dev-server-hmr/test-node/babel/customElements.test.js
@@ -1,6 +1,6 @@
 /* eslint-disable import/no-extraneous-dependencies */
 const { expect } = require('chai');
-const { banner, transform } = require('./utils');
+const { banner, transform } = require('./utils.js');
 
 describe('babelPluginWcHmr - detecting customElements.define', () => {
   it('injects registration when detecting a customElements.define', () => {

diff --git a/packages/dev-server-hmr/test-node/babel/decorators.test.js b/packages/dev-server-hmr/test-node/babel/decorators.test.js
@@ -1,7 +1,7 @@
 /* eslint-disable import/no-extraneous-dependencies */
 const { expect } = require('chai');
 const path = require('path');
-const { banner, transform, rootDir } = require('./utils');
+const { banner, transform, rootDir } = require('./utils.js');
 
 describe('babelPluginWcHmr - detecting decorators', () => {
   it('compiled decorator with decorator name', () => {

diff --git a/packages/dev-server-hmr/test-node/babel/functions.test.js b/packages/dev-server-hmr/test-node/babel/functions.test.js
@@ -1,7 +1,7 @@
 /* eslint-disable import/no-extraneous-dependencies */
 const { expect } = require('chai');
 const path = require('path');
-const { banner, transform, rootDir } = require('./utils');
+const { banner, transform, rootDir } = require('./utils.js');
 
 describe('babelPluginWcHmr - detecting function components', () => {
   it('global function name', () => {