dev-server should rewrite imports for json & css #2368
Replies: 2 comments 7 replies
-
|
Why do you think it should do that? what would be the use case? and why not write the import with the assert into the source directly? 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
because there are many libs wich have ESM code with css/json imports without asserts, cause they were used via bundlers. |
Beta Was this translation helpful? Give feedback.
-
|
The problem is that the bundler semantics are different from the standard semantics. Converting non-standard CSS/JSON imports to standard ones would just break apps. |
Beta Was this translation helpful? Give feedback.
-
|
moreover, the non-standard |
Beta Was this translation helpful? Give feedback.
-
|
maybe, but when we do nothing, and keep the import as it is, the page will never work. cause javascript in browser could not import it without assert. |
Beta Was this translation helpful? Give feedback.
-
I'm not sure but it seems like there's a miscommunication happening here. WDS's model for this kind of non-standard import is to use bundler plugins to transform files on the fly. // web-dev-server.config.js
import { fromRollup } from '@web/dev-server-rollup';
import jsonRollup from '@rollup/plugin-json';
const json = fromRollup(jsonRollup);
export default {
plugins: [json()]
} |
Beta Was this translation helpful? Give feedback.
-
|
@bennypowers I did understand that. But why can't we add the assert to the css or json import when no bundler plugin is used, or the bundler plugin did not transform. We then know that the import will not work, so we could add. |
Beta Was this translation helpful? Give feedback.
-
dev-sevrer should rewrite imports for css & json. it should add an assert statement to it
see: https://web.dev/css-module-scripts/
Beta Was this translation helpful? Give feedback.
All reactions