Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@open-wc/eslint-config]: severity vulnerability in trim-newlines #2225

Open
jarrodek opened this issue Jun 8, 2021 · 4 comments
Open

[@open-wc/eslint-config]: severity vulnerability in trim-newlines #2225

jarrodek opened this issue Jun 8, 2021 · 4 comments

Comments

@jarrodek
Copy link
Contributor

jarrodek commented Jun 8, 2021

Yesterday I started seeing audit reports like this:

                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ trim-newlines                                                │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.0.1 <4.0.0 || >=4.0.1                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @open-wc/eslint-config [dev]                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @open-wc/eslint-config > eslint-plugin-wc >                  │
│               │ validate-element-name > meow > trim-newlines                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1753                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 high severity vulnerability in 1162 scanned packages
  1 vulnerability requires manual review. See the full report for details.

If possible, please, update the dependency.

@stephenwade
Copy link
Contributor

stephenwade commented Jun 10, 2021

This vulnerability doesn't affect meow and therefore doesn't affect us. You don't need to worry about it. sindresorhus/meow#185 (comment)

Fixing the alert will depend on all the packages in the chain updating to a version that doesn't trigger it. meow and validate-element-name have already been updated, but they also are ESM-only packages now and I don't know if eslint-plugin-wc can move to ESM yet. If that happens then @open-wc/eslint-config can update and resolve the alert, but I don't know if it will happen soon.

@jarrodek
Copy link
Contributor Author

I have to comply with organization standards and each alert like this means tons of messages from the info sec team to fix this and me explaining that this is a dev dependency and not really directly causing a vulnerability. It's not bad, but it is a pain :)

@stale
Copy link

stale bot commented Jul 8, 2021

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 8, 2021
@sanmai-NL
Copy link
Contributor

The stale bot may clean up issues for new features that do not gain traction, but of course not for QA issues. Please fix the bot.

@stale stale bot removed the inactive label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants