Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack.config.js does not pass commit linting #246

Closed
Westbrook opened this issue Feb 21, 2019 · 3 comments
Closed

webpack.config.js does not pass commit linting #246

Westbrook opened this issue Feb 21, 2019 · 3 comments

Comments

@Westbrook
Copy link
Contributor

The following lint errors occur when trying to commit webpack.config.js. Not sure if there's something requiring this, so they should use some sort of ignore commenting, or just a bunch of removals to be made here.

image

Will try to confirm later and put together a PR.

@daKmoR
Copy link
Member

daKmoR commented Feb 21, 2019

yes we probably should add **/*.config.js here: https://github.com/open-wc/open-wc/blob/master/packages/eslint-config/index.js#L15

that way you can use devDependencies in these config files 👍

@Westbrook
Copy link
Contributor Author

Cool, I can follow up with that PR later tonight or tomorrow.

@Westbrook
Copy link
Contributor Author

Closed via #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants