Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add ci #18

Merged
merged 11 commits into from
May 16, 2024
Merged

chore(ci): add ci #18

merged 11 commits into from
May 16, 2024

Conversation

indirection42
Copy link
Contributor

@indirection42 indirection42 commented May 14, 2024

  • add ci settings
  • add new make targets
  • Fix a lots of clippy warnings, most of which are caused by no_std and std settings. I use #[allow(dead_code)] or add conditional compilation cfg to solve them. I am not sure if it's the recommend practice. It's really verbose sometimes. For example, in scale_info crate, it's already use cfg_if to ensure that the exported APIs are stable in both std and no_std environments. However, when we use it, we still need to add conditional compilation #[cfg(not(feature="std"))] or #[allow(unused_imports)], otherwise clippy will complain.

close #14

@indirection42 indirection42 marked this pull request as ready for review May 14, 2024 09:04
Makefile Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@indirection42 indirection42 requested review from xlc and zjb0807 May 15, 2024 06:08
@indirection42 indirection42 merged commit a8cfc7b into master May 16, 2024
1 check passed
@indirection42 indirection42 deleted the add-ci branch May 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI
4 participants