XTokens refactor #706
Merged
XTokens refactor #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
commented
Feb 27, 2022
| ); | ||
| }); | ||
|
|
||
| // TODO: should have more tests after https://github.com/paritytech/polkadot/issues/4996 |
There was a problem hiding this comment.
should have more test to ensure MultiAsset is valid (fungible & non zero amount) after paritytech/polkadot#4996
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 74.70% 74.99% +0.28%
==========================================
Files 83 83
Lines 7282 7266 -16
==========================================
+ Hits 5440 5449 +9
+ Misses 1842 1817 -25
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified events so there is only one to deal with
Not allow zero amount because apparently it is not allowed paritytech/polkadot#4996