make feed_value FreeOperational #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Feb 10, 2020
xlc
approved these changes
Feb 11, 2020
|
@shaopengw the one call per block rule is going to break your oracle server. you will need to implement laminar-protocol/oracle-server#15 once this is integrated |
xlc
requested changes
Feb 11, 2020
There was a problem hiding this comment.
Actually you will also need to perform the check in _feed_values as well because it is possible to dispatch the call indirectly (e.g. via utility.batch) to bypass the check.
Add a hook OnRedundantCall (or other name if you can a better one) and call it when we detect a redundant call. Only do this in _feed_values not validate because validate may be called by tx pool, which is not on-chain.
|
we may want to generalize the one call per block rule to become one call per N blocks, but later |
xlc
reviewed
Feb 13, 2020
xlc
approved these changes
Feb 13, 2020
oracle/src/lib.rs
Outdated
| let mut accounts = <HasDispatched<T>>::get(); | ||
| if accounts.contains(&who) { | ||
| T::OnRedundantCall::multiple_calls_per_block(&who); | ||
| return Err(DispatchError::Module { |
There was a problem hiding this comment.
Suggested change
| return Err(DispatchError::Module { | |
| return Err(Error::<T>::UpdateAlreadyDispatched.into()); |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.