-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XNFT PoC] xtokens non-fungible multiassets support #966
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 85.32% 85.50% +0.17%
==========================================
Files 88 88
Lines 10476 10533 +57
==========================================
+ Hits 8939 9006 +67
+ Misses 1537 1527 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests to ensure sending nft are actually working?
A change to the
do_transfer_multiassets
: support of theNonFungible
fungibility for non-fee assets.This PR doesn't change the API of extrinsics that use the configurable
CurrencyId
since it is a PoC. In the future, we could alter theamount
argument to take the fungibility into account.So only the following extrinsics can be used to transfer an NFT asset:
transferMultiasset
transferMultiassetWithFee
transferMultiassets