Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XNFT PoC] xtokens non-fungible multiassets support #966

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

mrshiposha
Copy link
Contributor

A change to the do_transfer_multiassets: support of the NonFungible fungibility for non-fee assets.

This PR doesn't change the API of extrinsics that use the configurable CurrencyId since it is a PoC. In the future, we could alter the amount argument to take the fungibility into account.

So only the following extrinsics can be used to transfer an NFT asset:

  • transferMultiasset
  • transferMultiassetWithFee
  • transferMultiassets

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b45942e) 85.32% compared to head (dbcc789) 85.50%.

Files Patch % Lines
xtokens/src/lib.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage   85.32%   85.50%   +0.17%     
==========================================
  Files          88       88              
  Lines       10476    10533      +57     
==========================================
+ Hits         8939     9006      +67     
+ Misses       1537     1527      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests

@mrshiposha mrshiposha marked this pull request as draft November 17, 2023 13:44
@mrshiposha mrshiposha marked this pull request as ready for review November 17, 2023 14:35
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests to ensure sending nft are actually working?

@xlc xlc merged commit e196931 into open-web3-stack:master Nov 21, 2023
4 checks passed
simonsso pushed a commit to NodleCode/open-runtime-module-library that referenced this pull request Jan 4, 2024
)

* feat: xtokens non-fungible multiassets support PoC

* test: nft/fee related tests for multiasset transfer

* fix: do_transfer_multiassets zero fee issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants