Remove SDP munging for P2P mode. #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces SDP munging with setCodecPreference for P2P mode. Changes of OWT APIs are needed to fully support setCodecPreference. For example, OWT APIs allow different bitrate settings for different codecs, which is not supported by WebRTC, so only the first codec's bitrate setting takes effect at this time.
jianjunz
force-pushed
the
set-codec-preference
branch
from
5ebc7db
to
3b7b72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces SDP munging with setCodecPreference for P2P mode. Changes of OWT APIs are needed to fully support setCodecPreference. For example, OWT APIs allow different bitrate settings for different codecs, which is not supported by WebRTC, so only the first codec's bitrate setting takes effect at this time.