Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional file types for uploading models #1080

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

officialsahyaboutorabi
Copy link
Contributor

@officialsahyaboutorabi officialsahyaboutorabi commented Mar 7, 2024

Pull Request Checklist

  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description

[Insert a brief description of the changes made in this pull request]


Changelog Entry

Added

  • [List any new features or additions]

Fixed

  • [List any fixes or corrections]

Changed

  • [List any changes or updates]

Removed

  • [List any removed features or files]

@justinh-rahb
Copy link
Collaborator

justinh-rahb commented Mar 7, 2024

Did you test this? Ollama only supports GGUF.

EDIT: I stand corrected, apparently it does support PyTorch now, but only as .bin files.. with a custom build of Ollama, maybe? Honestly it's unclear from their docs.

@tjbck tjbck closed this Mar 7, 2024
@tjbck tjbck reopened this Mar 7, 2024
@tjbck tjbck changed the title Update Models.svelte feat: additional file types for uploading models Mar 7, 2024
@@ -589,7 +589,7 @@
on:change={() => {
console.log(modelInputFile);
}}
accept=".gguf"
accept=".gguf",".safetensors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be .bin and not .safetensors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of them might work. Although don't rely on me as I am not too sure. I will have a look into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could check I'd greatly appreciate it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let me know if there is anything else you need me to look at.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could check I'd greatly appreciate it!

@tjbck, So it looks like that the model I am trying to load uses .safetensors. However, a .bin is just a binary file and isn't really used for models other than the conversion process.

@tjbck tjbck marked this pull request as draft March 7, 2024 04:44
@tjbck tjbck changed the base branch from main to dev March 7, 2024 05:01
@tjbck
Copy link
Contributor

tjbck commented Mar 7, 2024

I'll merge this to our dev branch but I'm pretty sure we can't just directly upload .safetensors files, feel free to try it out with dev branch docker image and let us know your results.

@tjbck tjbck marked this pull request as ready for review March 7, 2024 05:02
@tjbck tjbck merged commit ef9a799 into open-webui:dev Mar 7, 2024
1 of 2 checks passed
@officialsahyaboutorabi
Copy link
Contributor Author

I'll merge this to our dev branch but I'm pretty sure we can't just directly upload .safetensors files, feel free to try it out with dev branch docker image and let us know your results.

How can I set up the dev branch docker image?

@justinh-rahb
Copy link
Collaborator

How can I set up the dev branch docker image?

docker pull ghcr.io/open-webui/open-webui:dev
docker rm -f open-webui
docker run -d -p 3000:8080 --add-host=host.docker.internal:host-gateway -v open-webui:/app/backend/data --name open-webui --restart always ghcr.io/open-webui/open-webui:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants