Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing of OPENAI_API_BASE_URLS env var #1109

Merged
merged 2 commits into from
Mar 9, 2024
Merged

fix: parsing of OPENAI_API_BASE_URLS env var #1109

merged 2 commits into from
Mar 9, 2024

Conversation

ther0bster
Copy link
Contributor

Pull Request Checklist

  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description

First, thanks for this great project!
Version v0.1.110 of open-webui introduced a feature that enables configuring multiple OpenAI API based endpoints.
Currently, these endpoints can be stored and configured with the OPENAI_API_KEYS and OPENAI_API_BASE_URLS env vars.
The env var OPENAI_API_BASE_URLS is currently not parsed correctly, because instead, the OPENAI_API_BASE_URL is parsed.
Tested by setting OPENAI_API_BASE_URLS="https://api.openai.com/v1;https://api.mistral.ai/v1".
This PR fixes the env var parsing.


Changelog Entry

Fixed

  • Fix parsing of OPENAI_API_BASE_URLS env var

@tjbck tjbck changed the base branch from main to dev March 9, 2024 03:30
@tjbck
Copy link
Contributor

tjbck commented Mar 9, 2024

Good catch, LGTM Thanks!

@tjbck tjbck merged commit 19700e9 into open-webui:dev Mar 9, 2024
@ther0bster ther0bster deleted the fix-openai-env-var-parsing branch March 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants