Callback for output method

[kolomiec]

Could you please add callback for output method because fs.writeFile is async.

output = function(download, name, callback) {
                        var result;
                        if (download == null) {
                            download = true;
                        }
                        if (name == null) {
                            name = "output.docx";
                        }

                        this.calcZip();
                        result = this.zip.generate();
                        if (download) {
                            if (env === 'node') {
                                fs.writeFile(process.cwd() + '/' + name, result, 'base64', function(err) {
                                    if (err) {
                                        throw err;
                                    }
                                    if (callback) {
                                        callback();
                                    }
                                    return console.log('file Saved');
                                });
                            } else {
                                document.location.href = "data:application/vnd.openxmlformats-officedocument.wordprocessingml.document;base64," + result;
                            }
                        }
                        return result;
                    };

[edi9999]

Done.

You would have to pull it from the git repository, npm has not been updated.

See the docs in the readme for more information

[kolomiec]

Thanks, great job!

2014-05-12 12:07 GMT+03:00 edi9999 notifications@github.com:

Closed #27 #27.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/27#event-120026495
.

Best regards, Sergey Kolomiec

Java for Web and Java for Android developer

Cherkassy, Ukraine

skype user: kolomiec_sergey_karpovich

Mobile: +380 (96) 84-73-594

[kolomiec]

Hey, you use
if (options.callback != null) {
return callback();
}

but you should use

        if (options.callback != null) {
          return options.callback();
        }

Please update.

2014-05-12 12:48 GMT+03:00 Sergey Kolomiec kolomiecsergeyk@gmail.com:

Thanks, great job!

2014-05-12 12:07 GMT+03:00 edi9999 notifications@github.com:

Closed #27 #27.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/27#event-120026495
.

Best regards, Sergey Kolomiec

Java for Web and Java for Android developer

Cherkassy, Ukraine

skype user: kolomiec_sergey_karpovich

Mobile: +380 (96) 84-73-594

Best regards, Sergey Kolomiec

Java for Web and Java for Android developer

Cherkassy, Ukraine

skype user: kolomiec_sergey_karpovich

Mobile: +380 (96) 84-73-594

[edi9999]

solved

[kolomiec]

Thanks!

2014-05-12 17:02 GMT+03:00 edi9999 notifications@github.com:

solved

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-42835380
.

Best regards, Sergey Kolomiec

Java for Web and Java for Android developer

Cherkassy, Ukraine

skype user: kolomiec_sergey_karpovich

Mobile: +380 (96) 84-73-594

[kolomiec]

Hey, I have sent you pull request. Please apply it

[kolomiec]

Hey, should I write some coffe script?

Best regards, Sergey Kolomiec

Java for Web and Java for Android developer

Cherkassy, Ukraine

skype user: kolomiec_sergey_karpovich

Mobile: +380 (96) 84-73-594

[edi9999]

Hi @kolomiec,

yes, I have answered you there: #32

Please use that link #32 and not this issue to talk about the pull request