[MAINTAIN-151] changed a default value of the frameborder attribute to 1 for video_embed_iframe element #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 1 for video_embed_iframe element
Closed
12 tasks
hamrant
suggested changes
Aug 3, 2021
| */ | ||
| function openy_media_video_element_info_alter(&$info) { | ||
| if (isset($info['video_embed_iframe'])) { | ||
| $info['video_embed_iframe']['#pre_render'][] = |
There was a problem hiding this comment.
@aleevas Let's add this function before default pre_render function
…ist for the prerenders functions for video_embed_iframe element
hamrant
approved these changes
Aug 3, 2021
podarok
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue, this PR is going to fix: MAINTAIN-151
Also this was discussed in this PR ymcatwincities/openy#2526
The fix should add the border to all embedded video entities
Steps for review
log as admin
go to edit node (blog post foe example)
to add a new External video entity
save node and verify that iframe has border=1
verify that for all themes