Feature/931 alfresco model packaging #1
Conversation
Create build-model.yml
|
@aboerma can you please give this a review? :-) |
There was a problem hiding this comment.
Some high-level remarks - mostly about really presenting this as something belonging to the Open Zaak community rather than implied ownership by Open.satisfaction. Open Zaak as a community project should stay neutral. Couldn't find a hard requirement, but the closest thing is probably https://github.com/open-zaak/open-zaak/blob/main/docs/introduction/open-source/public_code.md#create-reusable-and-portable-code.
Content-wise this looks fine to me with my very limited knowledge of Java stacks :-)
...-share/src/main/resources/alfresco/web-extension/messages/openzaak-alfresco-share.properties
Outdated
Show resolved
Hide resolved
...-share/src/main/resources/alfresco/web-extension/messages/openzaak-alfresco-share.properties
Outdated
Show resolved
Hide resolved
...-share/src/main/resources/alfresco/web-extension/messages/openzaak-alfresco-share.properties
Outdated
Show resolved
Hide resolved
...n/resources/alfresco/web-extension/openzaak-alfresco-share-slingshot-application-context.xml
Outdated
Show resolved
Hide resolved
|
Heb bovenstaande feature lokaal uitgechecked, gebuild en getest. Voor zover ik kan zien werkt alles zoals is beschreven in de README.md. Inhoudelijk heb ik geen opmerkingen, works as advertised. |
|
@sergei-maertens I made the requested changes. Please check the PR again. |
|
@timijntema thanks, will get to this ASAP, should be done some time this week |
The only part in the pipeline that does not work at the moment is the docker push. This requires privileges on the Openzaak dockerhub and I don't have those privileges.