compiler/checker: fix call to 'setValue' #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when assigning a value of a type T1 to a variable of type T2, if such assignment requires an implicit conversion then such conversion is performed at runtime, calling the 'OpConvert'. This is not correct and leads to problems. This commit avoids that by calling 'setValue' passing it the correct type instead of nil, so the conversion is performed at compile time. Fix #917. Co-authored-by: Marco Gazerro <gazerro@open2b.com>
zapateo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when assigning a value of a type T1 to a variable of type T2,
if such assignment requires an implicit conversion then such conversion
is performed at runtime, calling the 'OpConvert'.
This is not correct and leads to problems.
This commit avoids that by calling 'setValue' passing it the correct
type instead of nil, so the conversion is performed at compile time.
Fix #917.
Co-authored-by: Marco Gazerro gazerro@open2b.com