Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store chromosome names as HDF5 enum #46

Closed
nvictus opened this issue Mar 20, 2017 · 2 comments
Closed

Store chromosome names as HDF5 enum #46

nvictus opened this issue Mar 20, 2017 · 2 comments
Labels
Milestone

Comments

@nvictus
Copy link
Member

nvictus commented Mar 20, 2017

Rather than fixed-length strings, the chroms/name dataset should be stored as HDF5 enums, just as the bins/chrom dataset is.

@nvictus
Copy link
Member Author

nvictus commented Oct 31, 2017

Because of the header size limit, this is a bad idea. The only other thing to consider is whether to use variable length strings instead and whether to use UTF-8 encoding or just store bytes and assume ASCII as now.

@nvictus
Copy link
Member Author

nvictus commented Dec 31, 2018

Conclusion: ASCII for arrays of strings, Variable-length UTF-8 for single strings.

@nvictus nvictus closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant