-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring snipping & pileups #227
Comments
was this fixed @Phlya ? or should we convert to discussion? |
There will be a more user friendly API available imminently. So e.g. point 2 will be done internally. However the whole underlying Snipper API is not the most convenient and should be eventually replaced with perhaps dask? @golobor Maybe we should convert the issue to a discussion as you suggest though! Since we need to think about low-level API design. |
update 9/14/2022:
|
The major problem with pileups is that the pileup function does not know about regions and takes them from the input features dataframe.
The creation of the "region" column of features requires the user to run "assign_regions", which is a potentially obsolete and unnecessary step (see assign_regions needs to be fixed or removed #225).
An alternative is to take the regions directly from snipper object, but the pileup takes only its methods. Should we replace passing two functions with a single snipper instead? If not, why?The text was updated successfully, but these errors were encountered: