Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all binaries linked against extra / unneeded programs #2

Closed
laf0rge opened this issue Oct 17, 2017 · 2 comments
Closed

all binaries linked against extra / unneeded programs #2

laf0rge opened this issue Oct 17, 2017 · 2 comments
Labels
type:bug Open5GS bug

Comments

@laf0rge
Copy link
Contributor

laf0rge commented Oct 17, 2017

It seems that pgw, hss, mme, pcrf and sgw are all linked against libraries whose symbols they don't use:

dpkg-shlibdeps:` warning: package could avoid a useless dependency if debian/nextepc-pgw/usr/bin/nextepc-pgwd was not linked against libsnappy.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pgw/usr/bin/nextepc-pgwd was not linked against libgcrypt.so.20 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pgw/usr/bin/nextepc-pgwd was not linked against libssl.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pgw/usr/bin/nextepc-pgwd was not linked against libz.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pgw/usr/bin/nextepc-pgwd was not linked against libcrypto.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-hss/usr/bin/nextepc-hssd was not linked against libgcrypt.so.20 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-hss/usr/bin/nextepc-hssd was not linked against libz.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-hss/usr/bin/nextepc-hssd was not linked against libcrypto.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-hss/usr/bin/nextepc-hssd was not linked against libsnappy.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-hss/usr/bin/nextepc-hssd was not linked against libssl.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-mme/usr/bin/nextepc-mmed was not linked against libsnappy.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-mme/usr/bin/nextepc-mmed was not linked against libssl.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-mme/usr/bin/nextepc-mmed was not linked against libz.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-mme/usr/bin/nextepc-mmed was not linked against libcrypto.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-mme/usr/bin/nextepc-mmed was not linked against libgcrypt.so.20 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pcrf/usr/bin/nextepc-pcrfd was not linked against libgcrypt.so.20 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pcrf/usr/bin/nextepc-pcrfd was not linked against libsnappy.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pcrf/usr/bin/nextepc-pcrfd was not linked against libz.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pcrf/usr/bin/nextepc-pcrfd was not linked against libcrypto.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-pcrf/usr/bin/nextepc-pcrfd was not linked against libssl.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libsnappy.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libcrypto.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libgnutls.so.30 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libgcrypt.so.20 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libz.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libssl.so.1.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against librt.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libdl.so.2 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nextepc-sgw/usr/bin/nextepc-sgwd was not linked against libidn.so.11 (it uses none of the library's symbols)

@acetcom
Copy link
Member

acetcom commented Oct 18, 2017

You're right!. The reason is why I was a little lazy and just use the LIBS variable in all executables. Give me a little time. I'll check it out soon.

@acetcom acetcom added type:enhancement Enhance performance or improve usability of original features. type:bug Open5GS bug and removed type:enhancement Enhance performance or improve usability of original features. labels Oct 25, 2017
@acetcom
Copy link
Member

acetcom commented Nov 4, 2017

I've fixed the issue. Sorry for late.

Thank your for your comment!

@acetcom acetcom closed this as completed Jan 2, 2018
AbdallahRustom pushed a commit to AbdallahRustom/open5gs that referenced this issue Sep 13, 2023
* test

* test 2

* Base EIR functionality works, note tests currently don't when 'bool eir_enabled = true;' in emm-sm.c

* EIR config functionality added

* Removes some debug prints, all tests pass, no errors, no warnings

* Undo accidental removal of ogs timer

* Reverting commit, looks like the issue was due to my local open5gs being ahead of omni5gs

This reverts commit 0e051a6167ff89297236c47748f85a275dfb363c.

* Attemping to address weird file changed

* Some code cleaning

* Added what tests I could for s13 handler

* Removed refactor, eir functionality works for home lab setup

* Commit for testing functionality in lab

* Seemlingly fully featured eir (unit tests failing)

Co-authored-by: Ryan Dimsey <ryan@omnitouch.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Open5GS bug
Projects
None yet
Development

No branches or pull requests

2 participants