Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TAC configuration error #2700

Closed
ximatest opened this issue Oct 25, 2023 · 1 comment
Closed

[Bug]: TAC configuration error #2700

ximatest opened this issue Oct 25, 2023 · 1 comment
Labels
Housekeeping:ToClose Issues reviewed and closed. Old requests, issues which are not bug, feature or documentation request type:bug Open5GS bug

Comments

@ximatest
Copy link

Open5GS Release, Revision, or Tag

v2.6.4

Steps to reproduce

Hello everyone, I found that when configuring the TAC in the amf.yaml, if it is configured as tac: [1-2], it will report a configuration error "No amf.tai.plmn_id|tac in '/xxx/amf.yaml'".
However, if it is configured as tac: 1 or tac: [1-2,3], it succeeds.
After checking the code, it seems that the following condition lacks the check for list1.

if (self.served_tai[0].list0.tai[0].num == 0 && 
    self.served_tai[0].list2.num == 0) {
    ogs_error("No amf.tai.plmn_id|tac in '%s'", ogs_app()->file);
    return OGS_ERROR;
}

I think the following condition needs to be added. Can you please help confirm if it is okay?

if (self.served_tai[0].list0.tai[0].num == 0 && 
    self.served_tai[0].list1.tai[0].num == 0 &&
    self.served_tai[0].list2.num == 0) {
    ogs_error("No amf.tai.plmn_id|tac in '%s'", ogs_app()->file);
    return OGS_ERROR;
}

Logs

[amf] ERROR: No amf.tai.plmn_id|tac in '/xxx/amf.yaml'

Expected behaviour

It can correctly configure the TAC.

Observed Behaviour

no

eNodeB/gNodeB

No response

UE Models and versions

No response

@ximatest ximatest added the triage Triage label for new issues and feature requests label Oct 25, 2023
@acetcom acetcom added type:bug Open5GS bug Housekeeping:ToClose Issues reviewed and closed. Old requests, issues which are not bug, feature or documentation request and removed triage Triage label for new issues and feature requests labels Oct 28, 2023
Copy link

This issue has been closed automatically due to lack of activity. This has been done to try and reduce the amount of noise. Please do not comment any further. The Open5GS Team may choose to re-open this issue if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:ToClose Issues reviewed and closed. Old requests, issues which are not bug, feature or documentation request type:bug Open5GS bug
Projects
None yet
Development

No branches or pull requests

2 participants