open5gs/lib/pfcp/message.h：line 1094

[lijhnihaoa]

I think the member type of this structure should be ogs_pfcp_tlv_application_id_s_pfds_t，not ogs_pfcp_tlv_pfd_context_t. What do you think?

[lijhnihaoa]

One more question, the macro in the program defines the ED series. Why are 8 bits in bytes affected by byte order?

[acetcom]

Hi @lijhnihaoa

• PFD management request
  You're right!. I've fixed it in the master branch.
  Thank you so much!

• How Endianness Effects Bitfield Packing
  I'm not sure if the answer to your question can be replaced by the link http://mjfrazer.org/mjfrazer/bitfields/. If you are trying to suggest something better than current ED method I implemented, please let me know.

Thanks again!
Sukchan

[lijhnihaoa]

Thank you for understanding the effect of byte order on bit fields.

[github-actions]

This issue has been closed automatically due to lack of activity. This has been done to try and reduce the amount of noise. Please do not comment any further. The Open5GS Team may choose to re-open this issue if necessary.