need to return here to prevent segfault #1052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently encountered a strange situation where the UPF was given a junk packet and segfaulted. I am still investigating the cause of the junk packet (looks like encapsulation, might have more PRs later) but in the meantime, the segfault was caused at line 198 as a result of calling src_addr[k] when src_addr was never set.
I dont know the exact pfcp logic and am not clear if we should return NULL or OGS_ERROR. This seemed correct but I defer to your wisdom. On a related note, I am assuming/hoping that we should free the packet somewhere else along the line to avoid leaks?