[SMF] relocation of user-location-info on top level for Gx,Gy

[EugeneBogush]

Now "3GPP-User-Location-Info" located in the wrong place.

at according 3GPP TS 32.299 "3GPP-User-Location-Info" is 3GPP specific AVP, which used in CCR,
and must locate on top level, as below:

[acetcom]

@EugeneBogush

Thank you so much!
Sukchan

[pespin]

3GPP TS 32.299 version 16.2.0 Release 16 (https://www.etsi.org/deliver/etsi_ts/132200_132299/132299/16.02.00_60/ts_132299v160200p.pdf).

All references I find about "3GPP-User-Location-Info" are inside following AVPs:

Location-Info :: = < AVP Header: 3460>
ProSe-Direct-Communication-Reception-Data-Container :: = < AVP Header: 3461>
PS-Information :: = < AVP Header: 874>
Related- Change-Condition- Information :: = < AVP Header: 3925>
Service-Data-Container :: = < AVP Header: 2040>
Traffic-Data-Volumes :: = < AVP Header: 2046>

Specifically, the one where it used to be before this change, section "7.2.158 PS-Information AVP" states:

PS-Information :: = < AVP Header: 874>
...
  [ 3GPP-User-Location-Info ]

Furthermore, in 6.4.2 Credit-Control-Request message, this AVP doesn't show as listed as top level for the message.

So, can somebody explain why this patch is changing the previous state of things? Am I missing something? I don't see this patch providing specific references to back it, even though I requested them when I was pinged some weeks ago in the initial PR which introduced this AVP long time ago.

@acetcom @EugeneBogush

[acetcom]

I currently do not have time to review this part.

To @EugeneBogush
Could you please respond to @pespin's comment?

Thanks a lot!
Sukchan

[pespin]

@acetcom I'll submit a PR reverting the change in the next days if there's no answer from @EugeneBogush .

[EugeneBogush]

according with ETSI TS 129 212 release V16.4.0 https://www.etsi.org/deliver/etsi_ts/129200_129299/129212/16.04.00_60/ts_129212v160400p.pdf in 5.6.2 this AVP(3GPP-User-Location-Info) is present. <CC-Request> ::= < Diameter Header: 272, REQ, PXY > < Session-Id > [ DRMP ] { Auth-Application-Id } { Origin-Host } { Origin-Realm } { Destination-Realm } { CC-Request-Type } { CC-Request-Number } [ Credit-Management-Status ] [ Destination-Host ] [ Origin-State-Id ] *[ Subscription-Id ] [ OC-Supported-Features ] *[ Supported-Features ] [ TDF-Information ] [ Network-Request-Support ] *[ Packet-Filter-Information ] [ Packet-Filter-Operation ] [ Bearer-Identifier ] [ Bearer-Operation ] [ Dynamic-Address-Flag ] [ Dynamic-Address-Flag-Extension ] [ PDN-Connection-Charging-ID ] [ Framed-IP-Address ] [ Framed-Ipv6-Prefix ] [ IP-CAN-Type ] [ 3GPP-RAT-Type ] [ AN-Trusted ] [ RAT-Type ] [ Termination-Cause ] [ User-Equipment-Info ] [ QoS-Information ] [ QoS-Negotiation ] [ QoS-Upgrade ] [ Default-EPS-Bearer-QoS ] [ Default-QoS-Information ] 0*2 [ AN-GW-Address ] [ AN-GW-Status ] [ 3GPP-SGSN-MCC-MNC ] [ 3GPP-SGSN-Address ] [ 3GPP-SGSN-Ipv6-Address ] [ 3GPP-GGSN-Address ] [ 3GPP-GGSN-Ipv6-Address ] [ 3GPP-Selection-Mode ] [ RAI ] [ 3GPP-User-Location-Info ] [ Fixed-User-Location-Info ] [ User-Location-Info-Time ] [ User-CSG-Information ] [ TWAN-Identifier ] [ 3GPP-MS-TimeZone ] *[ RAN-NAS-Release-Cause ] [ 3GPP-Charging-Characteristics ] [ Called-Station-Id ] [ PDN-Connection-ID ] [ Bearer-Usage ] [ Online ] [ Offline ] *[ TFT-Packet-Filter-Information ] *[ Charging-Rule-Report ] *[ Application-Detection-Information ] *[ Event-Trigger ] [ Event-Report-Indication ] [ Access-Network-Charging-Address ] *[ Access-Network-Charging-Identifier-Gx ] *[ CoA-Information ] *[ Usage-Monitoring-Information ] [ NBIFOM-Support ] [ NBIFOM-Mode ] [ Default-Access ] [ Origination-Time-Stamp ] [ Maximum-Wait-Time ] [ Access-Availability-Change-Reason ] [ Routing-Rule-Install ] [ Routing-Rule-Remove ] [ HeNB-Local-IP-Address ] [ UE-Local-IP-Address ] [ UDP-Source-Port ] [ TCP-Source-Port ] *[ Presence-Reporting-Area-Information ] [ Logical-Access-ID ] [ Physical-Access-ID ] *[ Proxy-Info ] *[ Route-Record ] [ 3GPP-PS-Data-Off-Status ] *[ AVP ] пн, 12 черв. 2023 р. о 11:55 Pau Espin Pedrol ***@***.***> пише:

…

@acetcom <https://github.com/acetcom> I'll submit a PR reverting the change in the next days if there's no answer from @EugeneBogush <https://github.com/EugeneBogush> . — Reply to this email directly, view it on GitHub <#2331 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANXAKWE5SODBYQPSWFKMODXK3KPPANCNFSM6AAAAAAYKUPBGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Yours faithfully,* *Eugene B.*

[pespin]

Ok I understand the issue now. TS 129 212 you shared seems to specify the Gx interface, while TS 32.299 specifies the Gy interface. The position of the AVP is different in each interface.

@EugeneBogush do you mind submitting a patch reverting the Gy part of your commit?

[EugeneBogush]

@EugeneBogush do you mind submitting a patch reverting the Gy part of your commit?

Yes, but you need to understand where to insert 3gpp-User-location-info for Gy
and this applies not only to 3GPP-User-Location-Info

[pespin]

@EugeneBogush not sure what you mean. The 3gpp-User-location-info was in the good place before your patch, so all you need to do is to revert your changes in src/smf/gy-path.c.

[EugeneBogush]

so all you need to do is to revert your changes in src/smf/gy-path.c.

but it will not correctly.

earlier you mentioned the PS-information field, I think it's more correct to place it here

PS-Information :: = < AVP Header: 874>
...
[ 3GPP-User-Location-Info ]

[pespin]

@EugeneBogush it was already in PS-Information before your change:

    /* PS-Information, TS 32.299 sec 7.2.158 */
    ret = fd_msg_avp_new(ogs_diam_gy_ps_information, 0, &avpch1);
...
    /* 3GPP-User-Location-Info, 3GPP TS 29.061 16.4.7.2 22 */
    smf_fd_msg_avp_add_3gpp_uli(sess, avpch1);

It's also validated in our TTCN3 tests:
https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/ggsn_tests/GGSN_Tests.ttcn#L552
https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-ogs/465/artifact/logs/ggsn-tester/GGSN_Tests.TC_gy_charging_cc_time.pcap.gz

[EugeneBogush]

it was already in PS-Information before your change:

yes, sorry.