[MME] [AMF] Set Daylight Saving Time #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why you deleted the case where id_dst is 0? I'm worried that it might cause other problems because it differs from the existing code. Could you please check if it's okay not to give this value? Thanks a lot! |
Fix DST always being set to 0 ("No adjustment for Daylight
Saving Time").
Related: 3GPP TS 24.008 § 10.5.3.12
|
The IE is optional according to the spec. But I've changed the patch to not omit it if no DST is set, so it is more similar to current behavior. Could you take another look at it? |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DST always being set to 0 ("No adjustment for Daylight Saving Time").
Related: 3GPP TS 24.008 § 10.5.3.12