Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMF] Fix Volume/Time Threshold conversion Gy->PFCP #3113

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

pespin
Copy link
Contributor

@pespin pespin commented Apr 5, 2024

AS shown in 3GPP TS 29.244 C.2.1.1 diagram, the meaning of Threshold value is different in Diameter Gy and in PFCP interfaces. In Diameter Gy the value sets the trigger for the "remaining credit", while in PFCP the value sets the trigger for the "used credit".

ThresholdPFCP = Quota - ThresholdGy

@acetcom
Copy link
Member

acetcom commented Apr 6, 2024

@pespin

I was unaware of your pull request, which included the incorrect commit (3064861) being completely removed due to a git reset --hard.

Could you please pull request your fix again?

AS shown in 3GPP TS 29.244 C.2.1.1 diagram, the meaning of Threshold
value is different in Diameter Gy and in PFCP interfaces.
In Diameter Gy the value sets the trigger for the "remaining credit",
while in PFCP the value sets the trigger for the "used credit".

ThresholdPFCP = Quota - ThresholdGy
@pespin
Copy link
Contributor Author

pespin commented Apr 6, 2024

@acetcom I rebased the branch on top of current main and resubmitted. I suggest you avoid recreating the "main" branch history in the future and instead do revert, otherwise you may create problems for a lot of people or automated jobs pulling from it.

@acetcom acetcom merged commit e078b33 into open5gs:main Apr 6, 2024
5 checks passed
@pespin pespin deleted the pespin/smf-threshold-fix branch April 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants