Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default NodeSet xml file lacks ModellingRules nodes #1977

Closed
1 of 7 tasks
jonasgreen88 opened this issue Aug 13, 2018 · 3 comments
Closed
1 of 7 tasks

Default NodeSet xml file lacks ModellingRules nodes #1977

jonasgreen88 opened this issue Aug 13, 2018 · 3 comments
Assignees

Comments

@jonasgreen88
Copy link
Contributor

jonasgreen88 commented Aug 13, 2018

Description

The minimal NodeSet xml file used as default NodeSet by cmake lacks the ModellingRules nodes "Mandatory" and "Optional". According to the OPC specification Part 5, chapter 6.3.2 ServerCapabilitiesType: "ModellingRules is an entry point to browse to all ModellingRules supported by the Server. All ModellingRules supported by the Server should be able to be browsed starting from this Object."

Do you guys interpret the specification differently or have the nodes just been forgotten to be added?

<UAObject NodeId="i=2996" BrowseName="ModellingRules" ParentNodeId="i=2268">

I can also see that the same xml file on 0.3 branch lacks some more mandatory nodes of the ServerObject (AggregateFunctions, ModellingRules, VendorServerInfo). Will the ServerObject nodes added to the NodeSet on the master branch be merged to 0.3 before release?

<?xml version="1.0" encoding="utf-8"?>

Background Information / Reproduction Steps

Checklist

Please provide the following information:

  • open62541 Version (release number or git tag): 02734c3
  • Other OPC UA SDKs used (client or server):
  • Operating system:
  • Logs (with UA_LOGLEVEL set as low as necessary) attached
  • Wireshark network dump attached
  • Self-contained code example attached
  • Critical issue
@jpfr
Copy link
Member

jpfr commented Aug 15, 2018

On master, we support three levels of completeness for namespace zero.
Minimal (no generated code), reduced (default) and full.

Which parts of namespace zero we include where is up for debate.
In the future, we might have the Opc.Ua.NodeSet2.PartNN.xml files individually selectable.
https://opcfoundation.org/UA/schemas/1.04/

Feel free to propose a pull request with specific changes.

@Pro Pro added this to the 0.3 milestone Aug 21, 2018
@Pro
Copy link
Member

Pro commented Aug 21, 2018

Summary from the TelCo: @jonasgreen88 will have a look at it. This feature is already in master and only needs to be merged into 0.3

@Pro
Copy link
Member

Pro commented Aug 23, 2018

Merged in #2000

@Pro Pro closed this as completed Aug 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants