Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cherry-picked commits from master to 0.3 #2000

Merged
merged 12 commits into from Aug 24, 2018
Merged

Backport cherry-picked commits from master to 0.3 #2000

merged 12 commits into from Aug 24, 2018

Conversation

Pro
Copy link
Member

@Pro Pro commented Aug 22, 2018

If you find additional commits which should also be backported from master please leave a note here

- rename subscription variable sequence number to nextSequenceNumber
- adjust logic
Fixes #4202 - Wrong Supertype.
@coveralls
Copy link

coveralls commented Aug 22, 2018

Coverage Status

Coverage increased (+0.3%) to 77.073% when pulling 36022eb on backport_03 into 215651a on 0.3.

@jonasgreen88
Copy link
Contributor

@Pro We dicussed to include this pull request yesterday at the meeting: #1885

@jonasgreen88
Copy link
Contributor

Also a set of commits updating the Opc.Ua.NodeSet2.Minimal.xml was decided to be merged.

jonasgreen88 and others added 5 commits August 23, 2018 09:05
If there are a set of timer callbacks in the timer list that are
executed in the same timer process cycle the order of them were
inversed every time after they had been executed, except the first
callback. Also, if a set of timer callbacks with same timer interval
are added within 1 second of each other, they are synchronized to
expire at the same time and added in front of each other, except the
first one which will keep the first position. If four timer callbacks
with the same time interval are added after each other they are put
in the timer list in the following order: #1, #4, #3, #2.

This change fixes so callback timers that will be executed with
the same time interval and that are put together in a "block" in the
timer list are not inversed within this block after each execution of
them. It also fixes so all timers within a "block" are added in a
deterministic order. As described above they where added in reversed
order to the timer list except the first one. Now all timers that can
be put together in a "block" are added in reversed order within this
block. One advantage of putting the callback timers in reversed order
is if a subscription with a set of monitored items are created with
the same publish/sampling interval. In that case the monitored items
that are created after the subscription has been created will be
executed by the timer process before the subscription's publish
function is called. This execution order will cause minimum delay
of data notifications to be published.
add more required nodes for the minimal nodeset
The ModellingRules node of the Server object shall reference the
modelling rules that the server supports. This server supports the
modelling rules mandatory and optional.
@Pro Pro changed the title Cherry-picked commits from master Backport cherry-picked commits from master to 0.3 Aug 23, 2018
@Pro Pro merged commit 4904863 into 0.3 Aug 24, 2018
@Pro Pro deleted the backport_03 branch August 24, 2018 07:12
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants