Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test historical_data test randomly crash (SEGFAULT) #2330

Closed
1 task done
StalderT opened this issue Dec 28, 2018 · 3 comments · Fixed by #2342
Closed
1 task done

Unit test historical_data test randomly crash (SEGFAULT) #2330

StalderT opened this issue Dec 28, 2018 · 3 comments · Fixed by #2342

Comments

@StalderT
Copy link
Contributor

StalderT commented Dec 28, 2018 •
edited
Loading

Description

Unit test historical_data test randomly crash (SEGFAULT) see : https://travis-ci.org/open62541/open62541/jobs/473063184#L9687

Checklist

Please provide the following information:

  • open62541 Version (release number or git tag): master
@StalderT StalderT changed the title historical_data test randomly crash (SEGFAULT) Unit test historical_data test randomly crash (SEGFAULT) Dec 28, 2018
@StalderT StalderT mentioned this issue Jan 3, 2019
Closed
@Pro
Copy link
Member

Pro commented Jan 3, 2019

See also https://travis-ci.org/open62541/open62541/jobs/474423872#L8280

@Pro
Copy link
Member

Pro commented Jan 3, 2019

image

Found the issue. There's a race condition:
startPoll is creating a monitored item, and stopPoll is deleting it. Meanwile serverloop is executing UA_Server_run_iterate which is accessing the deleted timer object for the monitored item.

I'll create a fix for that.

@StalderT
Copy link
Contributor Author

StalderT commented Jan 3, 2019

Thanks

Pro added a commit that referenced this issue Jan 3, 2019
@Pro
Tests: Mutex access to server to avoid race condition.
77c201f 
Fixes #2330
@Pro Pro mentioned this issue Jan 3, 2019
Merged
Pro added a commit that referenced this issue Jan 3, 2019
@Pro
Tests: Mutex access to server to avoid race condition.
74ee393 
Fixes #2330
Pro added a commit that referenced this issue Jan 3, 2019
@Pro
Tests: Mutex access to server to avoid race condition.
c90eec3 
Fixes #2330
Pro added a commit that referenced this issue Jan 3, 2019
@Pro
Tests: Mutex access to server to avoid race condition.
cf0f9b9 
Fixes #2330
@Pro Pro closed this as completed in #2342 Jan 3, 2019
Pro added a commit that referenced this issue Jan 3, 2019
@Pro
Tests: Mutex access to server to avoid race condition.
96e1365 
Fixes #2330
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Historical Data Unit Test random failure open62541/open62541
2 participants
@Pro @StalderT