[0.3 Backport] NodesetCompiler: Hide valueRank not supported warning #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The valueRank for data types is currently not used in the nodeset compiler and thus we can hide the warning. The rest of the code still works. This valueRank attribute should then later on be used when creating data type definitions on the fly with fixed array size instead of malloc arrays.
Pro
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valueRank for data types is currently not used in the nodeset compiler
and thus we can hide the warning. The rest of the code still works.
This valueRank attribute should then later on be used when creating
data type definitions on the fly with fixed array size instead of malloc
arrays.
See also #2137