WIP: Networking code overhaul #2271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlgiraud
force-pushed
the
feature/overhaul/network2
branch
5 times, most recently
from
be3b701
to
1edfbfe
Compare
mlgiraud
force-pushed
the
feature/overhaul/network2
branch
from
1edfbfe
to
0aebc31
Compare
7 tasks
mlgiraud
force-pushed
the
feature/overhaul/network2
branch
3 times, most recently
from
f92434e
to
a20c157
Compare
mlgiraud
force-pushed
the
feature/overhaul/network2
branch
from
a86204b
to
81e0447
Compare
|
This pull request introduces 1 alert when merging eec4cf5 into bc47ffc - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 1f4468e into acd2f4a - view on LGTM.com new alerts:
Comment posted by LGTM.com |
mlgiraud
force-pushed
the
feature/overhaul/network2
branch
from
8059307
to
e3c69f3
Compare
|
This pull request introduces 1 alert when merging e3c69f3 into acd2f4a - view on LGTM.com new alerts:
Comment posted by LGTM.com |
mlgiraud
force-pushed
the
feature/overhaul/network2
branch
from
7a89379
to
2864996
Compare
|
Continued in #2408 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to overhaul large parts of the networking code to reduce coupling and unify client and server networking.
I will be updating this pull request with a more detailed description as work progresses.
I made a small python prototype to test the structure which can be found in the concepts directory.Deleted, because not needed anymore.
Steps until completion:
After the server side is up and running again start working on the client(separate PR)A separate PR will most probably not be possible. There are too many dependencies to make a clean cut imho.